The constraints file used for tsconfig and root was removed.
We need to update the file to use the StarlingX Debian constraints file.
Test Plan:
PASS: Run tox for tsconfig and root dir
Closes-bug: 2055734
Change-Id: I3b2430008a8f6c76a41457b2e4ea01f7b529854c
Signed-off-by: Hugo Brito <hugo.brito@windriver.com>
This change will allow this repo to pass zuul now
that this has merged:
https://review.opendev.org/c/zuul/zuul-jobs/+/866943
Tox 4 deprecated whitelist_externals.
Replace whitelist_externals with allowlist_externals
skipsdist and usedevelop are incompatible in tox 4.
Setting tox < 4 in .zuul.yaml rather than trying to
figure out why the sysinv component is not properly
installing in tox.
Partial-Bug: #1997255
Signed-off-by: Al Bailey <al.bailey@windriver.com>
Change-Id: If8e339d20e57e0830ea4ce27c098bacfef2f2ef8
Ignore new warnings:
- SC2320: This $? refers to echo/printf, not a previous command.
- SC2317: Command appears to be unreachable. Check usage (or ignore if
invoked indirectly).
Change-Id: I3d9e616c7a27b57b0f3f33d516c82bc13ba1faef
Signed-off-by: Robert Church <robert.church@windriver.com>
Change-Id: Idb260b1a75f1e1f0f99c95ad1cc41904539d2ce1
The '.sh' files are examined by bashate but now the linters
command will also run a shellcheck on them.
The majority of the shellcheck errors that are failing
have been suppressed, and can be updated and fixed by
subsequent submissions.
Shell scripts that do not end in .sh will also be examined
by bashate and shellcheck.
Story: 2008943
Task: 42566
Signed-off-by: albailey <Al.Bailey@windriver.com>
Change-Id: Ie5c58ec9391ed76bfe34b3544972306341fafcc4
There was a file that was missing a newline which would
cause bashate to fail.
However the bashate command was being run as a list of inputs
rather than as individual files, so that error was being ignored
unless that bad file was the last file processed.
This submission fixes the file, and ensures that tox linters
job will fail is any file has an error, regardless of what is
processed afterwards.
Change-Id: I7587b7017b6855aad63dfaeaea5ecca0bcfc21ea
Closes-Bug: 1890287
Signed-off-by: albailey <Al.Bailey@windriver.com>
Adding a zuul job so that any new bandit failures
will be caught.
Switching bandit to run in python3.
B111 plugin was removed from bandit by:
PyCQA/bandit@d93eed5
Cleanup the list of bandit checks that need to be skipped
in order for this tox job to pass. Those checks can be
removed when the code is updated by future commits.
Story: 2004515
Task: 37744
Change-Id: I1809b1124a5a693d288fb7ea893f30c24487af36
Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
List of relocated subdirectories:
kubernetes/platform/stx-platform/stx-platform-helm
kubernetes/helm-charts/ceph-pools-audit
kubernetes/helm-charts/rbd-provisioner
Story: 2006166
Task: 35687
Depends-On: I665dc7fabbfffc798ad57843eb74dca16e7647a3
Change-Id: I9fff4d9f973fea151812f516859b0c9ce190afb8
Signed-off-by: Scott Little <scott.little@windriver.com>
Depends-On: Ibca91cc733e27cd9fb4926b7151cfa8a7976a59d
Signed-off-by: Scott Little <scott.little@windriver.com>
This updates the upper-constraints.txt used by tox for
installing python modules to reference the stable/stein
constraints.
Change-Id: Ia3a145933e44aca016e84024dca4131dd778ecce
Closes-Bug: 1834216
Signed-off-by: Don Penney <don.penney@windriver.com>
This update adds the tox and zuul configuration to
run puppet-lint against the puppet manifests. The
initial update ignores all existing errors, which
will be cleaned up later.
Change-Id: I293abc2eac6bc6216cbbf6d939c1ba3474fb9384
Story: 2004515
Task: 28665
Signed-off-by: Don Penney <don.penney@windriver.com>
hacking and flake8 have compatability issues.
By specifying the version of hacking to be the same
as what other openstack components are using, we
clamp the version of flake8 and allow for reliable
hacking checks.
Change-Id: I8ab1543c030439903d99fffec1a9e3a264f20a80
Story: 2004515
Task: 28571
Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
A few updates:
- Enable yamllint on the application manifests
- Fix truthy warnings from the linter
- Fix indentation issue with the horizon conf section and the
ceilometer db_sync section which invalidates the yaml formatting.
- Disable the openstack-telemetry chart group as this will not work due
to dependencies on panko which hasn't been fully integrated yet.
NOTE: Problems highlighted by yamllint in the manifests may not
necessarily be real issues as these are not actually guaranteed to be
standards-compliant YAML files until after they have been run through
the pre-processor (i.e. armada). The goal of using yamllint here is to
catch gross structural errors but any other errors may need to be
evaluated on a case-by-case basis and excluded from the linter after
validation with armada.
Change-Id: Ic604e61e0d6354d56a687c6876cd8d83cae75afc
Story: 2004005
Task: 27801
Signed-off-by: Robert Church <robert.church@windriver.com>
Use an application RPM to build and collect application artifacts.
This follows the same mechanism that is used to build the openstack-helm
and openstack-helm-infra charts. The custom StarlingX charts are built
and the application specific armada manifests are included in the RPM.
This application RPM will be used to produce some of the required build
artifacts (custom helm tarballs + armada manifests) but is not intended
to be installed on the system. These artifacts are extracted later for
proper application packaging with additional required metadata.
Changes also include:
- Update the README describing the new layouts for applications.
- Move the nova-api-proxy chart from the common area to be included as
a chart specific to the stx-openstack app.
Change-Id: I1140760d56035249324519be93bb913e18f394d9
Story: 2004005
Task: 27801
Depends-On: I57c5ec5f3565e9e585f0935af745e495699aa28c
Signed-off-by: Robert Church <robert.church@windriver.com>
New helm chart created for nova-api-proxy
New module added to helm overrides to configure nova-api-proxy.conf
Turned of yamllint for helm charts, openstack helm charts are yaml
files but not proper yaml syntax
Story: 2004007
Task: 26953
Change-Id: Ic45d6cb801e142ddd7fc7da1638ba0e65cbacc22
Signed-off-by: Lachlan Plant <lachlan.plant@windriver.com>
We are using openstackdocstheme >= 1.26.0 which is well beyong
what is in stable/pike upper-constraints.txt.
Change-Id: I29a5b69784c791d84ab5e33e8077e010e8fdb9c8
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: Ib5574149623a8dd92dae34d1ec1cdd9999f31609
Baseline changes to comply with Release Notes Management
based in Reno [0]:
* Use build-openstack-releasenotes job for release notes
(We can't use the OpenStack releasenotes template as it includes
publish jobs, stx needs its own)
* Add newnote tox environment as convenience for creating new release
notes, re-using the releasenotes venv.
* Remove the unused 'true' tox environment if it exists.
[0] https://docs.openstack.org/reno/latest/
Story: 2003101
Task: 26514
Change-Id: I7fda1f84d336940dc8851eb053d451981e36bf4d
Signed-off-by: Abraham Arce <abraham.arce.moreno@intel.com>
Listed below are the errors which were fixed as well as the actions
[error] trailing spaces (trailing-spaces)
--> delete spaces
[error] too many blank lines (3 > 2)
--> delete blank line
[error] too few spaces after comma (commas)
--> add space after comma
[error] too many spaces inside brackets
--> delete extra spaces
[error] wrong indentation: expected XX but found XX (indentation)
--> delete/add spaces to indente
[error] line too long (97 > 80 characters) (line-length)
--> change the line max length to 200
cut the too long lines to 2 or 3 (by using '|-')
[error] duplication of key "XXX" in mapping (key-duplicates)
--> delete the duplication
[warning] missing starting space in comment (comments)
--> add blank after '#'
[warning] truthy value should be true or false (truthy)
--> lower case "False"/"True" to false/true
Listed below are test cases done which run one controller and one compute in KVMs
Test-Install ---- success
Test_create_instance ---- success
Now linters errors under stx-config is clear. Weee!!
Related commit: https://review.openstack.org/#/c/600473/
Story: 2003360
Task: 24411
Change-Id: Idc3c9304172be52c5d2fb2cbd862527066b72ecf
Signed-off-by: SidneyAn <ran1.an@intel.com>
Listed below are the errors which were fixed as well as the actions
taken to fix them:
E010: do not on the same line as for
--> let do and for in the same line
E011: then not on the same line as if or elif
--> let then and if or elif in the same line
E020: Function declaration not in format ^function name {$
--> fix the format to suit ^function name {$
E041: Usage of $[ for arithmetic is deprecated for $((
--> fix from $[ to $((
E043: arithmetic compound has inconsistent return semantics
--> do not use +=, ++, -=, --; use value=value+? instead.
E001: check that lines do not end with trailing whitespace
--> delete trailing whitespace
E003: ensure all indents are a multiple of 4 spaces
--> add/delete spaces
E042: local declaration hides errors
--> let declaration and assignment in two lines.
Listed below are test cases done which run one controller
and one compute in KVMs
Test-Install ---- success
Related: https://review.openstack.org/#/c/600663/https://review.openstack.org/#/c/601221/
Story: 2003360
Task: 26213
Change-Id: I3ece37db3a326ea58bd344f43beefcbbbd4f0ad4
Signed-off-by: SidneyAn <ran1.an@intel.com>
Hugo Brito