starlingx
/
ha
Code Issues Proposed changes

Fix a major logic error 

If in_transition is false, the result of in_transition is always false
with '&&', so we should be changed '&&' to '||'.

Change-Id: I8c18c052c94ebfdbcbcec215d64a8bceeda34f27
Closes-Bug: #1809412
This commit is contained in:
Austin 2018-12-21 15:21:29 +08:00
parent 9cc9ce0a2d
commit 8350ded5fc
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
service-mgmt/sm-1.0.0/src/sm_failover.c
View File

@ -910,13 +910,13 @@ void sm_failover_audit()
bool in_transition = false;
bool infra_configured = is_infra_configured();
in_transition = in_transition &&
in_transition = in_transition ||
sm_failover_if_transit_state(_mgmt_interface_info);
in_transition = in_transition &&
in_transition = in_transition ||
sm_failover_if_transit_state(_oam_interface_info);
if( infra_configured )
{
in_transition = in_transition &&
in_transition = in_transition ||
sm_failover_if_transit_state(_infra_interface_info);
}