A New version of setuptools was released July 14 2023
which does not work with the pbr version for this branch.
The fix is based on
https://review.opendev.org/c/openstack/ceilometer/+/888711
The 'requires' tag in tox was added in 3.2
setuptools is capped in tox.ini
tox is also capped.
Signed-off-by: Al Bailey <al.bailey@windriver.com>
Change-Id: I737885d2e6e2242e8fcb121e87611fd86d43a9db
This change will allow this repo to pass zuul now
that this has merged:
https://review.opendev.org/c/zuul/zuul-jobs/+/866943
Tox 4 deprecated whitelist_externals.
Replace whitelist_externals with allowlist_externals
Partial-Bug: #2000399
Signed-off-by: Al Bailey <al.bailey@windriver.com>
Change-Id: Iceb323a8b7a4b6ec8af81cd1b07c8b98d1e4b3f2
Legacy-resolver will have its support dropped in the future.
Also, legacy-resolver was masking a dependency conflict that
required the constraints files be updated. To use the
updated constraints file, the stx-integ-pylint job had to be
updated. This update matches what is done in other repos,
eg. https://github.com/starlingx/update/blob/master/.zuul.yaml#L108.
Test Plan:
Execute: tox
Closes-Bug: 1964372
Signed-off-by: Joshua Kraitberg <joshua.kraitberg@windriver.com>
Change-Id: I6b71f0cd3d9315f957d6a6a15bf0a22e2a692185
pylint is currently only running on storage_topology
however it was using generic dependencies and installing
and suppressing far more than it needed to.
This will get pylint to pass zuul as well, since some
of the un-needed dependencies are failing to install.
Story: 2008943
Task: 43850
Signed-off-by: albailey <Al.Bailey@windriver.com>
Change-Id: I250754ca8f4f904a902f6cfd6597fde54d1597a9
This patch updates kexec-tools from 2.0.15 to 2.0.21 (and its supporting
software package makedumpfile from 1.6.2 to 1.6.9) for compatibility
with the newer v5.10 kernel.
This commit clones the kexec-tools package's supporting files from
commit 26a7a543427eac59ed39728466f3d95d320f735a in the CentOS RPM
packaging git repository. Links for reference:
- 26a7a54342?branch=c7
- 26a7a54342
Please note that this patch causes the build system to pull in and
extract an SRPM file to acquire:
kdump-anaconda-addon-003-29-g4c517c5.tar.gz
This is done for security, because the only public reference to commit
4c517c5 is on a Red Hat developer's personal Github account:
https://github.com/ryncsn/kdump-anaconda-addon/commits/rhel-7
kexec-tools package's supporting files cloned by this commit trigger a
large number of shell script linting errors. Given that the shell
scripts in question are inherited from upstream (i.e., CentOS 7), the
"files" directory of this package is excluded from automated linting via
the changes in tox.ini.
Verification: A kexec-tools RPM package built with this commit was
installed onto an existing StarlingX system. A vmcore file was
succesfully collected from a kernel crash triggered with
/proc/sysrq-trigger. A recent version of the crash utility was found to
succesfully parse the collected vmcore file.
Credits: Thanks to Jiping Ma for helping with cleaning up and publishing
an earlier version of this patch.
Story: 2008921
Task: 43040
Depends-On: https://review.opendev.org/c/starlingx/tools/+/805127
Signed-off-by: Jiping Ma <jiping.ma2@windriver.com>
Signed-off-by: M. Vefa Bicakci <vefa.bicakci@windriver.com>
Change-Id: Idc4e523610e4c09259300c8b67ea5e0fbe59c611
Due to a recent change in fm-api's directory structure, unit tests would
fail since the virtualenv would not be able to find fm-api/setup.py.
Adjust the tox.ini to point to the correct directory. Tested locally
by running tox.ini.
Depends-On: https://review.opendev.org/c/starlingx/fault/+/806046
Story: 2009101
Task: 43091
Signed-off-by: Charles Short <charles.short@windriver.com>
Change-Id: I6e09735bca06a5c9f0868b58ae7de344299ef570
A lot of work has gone into making sure that StarlingX is python3
compatible. To ensure future compatibility, enable the python3
portability checks. Disable the checks that are raising errors.
Another set of commits will address the offending code.
Story: 2006796
Task: 43273
Signed-off-by: Bernardo Decco <bernardo.deccodesiqueira@windriver.com>
Change-Id: Ic4b51f71f1680b78b70e05785aca15150e7e5b2a
In order to minimize latency as much as possible, we want to allow
kubernetes containers to make use of CPUs which have been specified
as "isolated" via the kernel boot args.
This commit creates an isolcpus device plugin, which detects the isolated
CPUs and exports them to kubelet via the device plugin API.
See kubernetes/plugins/isolcpus-device-plugin/files/README.md for
more information on the behaviour and design choices for this commit.
When we move to a newer version of the Intel device plugin manager we
may be able to simplify some of this. See the above README.md file
for details.
Change-Id: I3bfe04ab6e7fbafefa63f6dc43cb2ed79a52579f
Story: 2008760
Task: 42165
Signed-off-by: Chris Friesen <chris.friesen@windriver.com>
pylint zuul jobs are failing due to incompatible dependencies that
cause the new version of pip to abort.
Enabling the legacy resolver (for now) so zuul can pass, while we
fix all the requirements across the different repos.
Change-Id: I8837e1372f1901afe4e9acbfca3132b0674a876f
Related-Bug: 1907125
Co-Authored-By: albailey <Al.Bailey@windriver.com>
Signed-off-by: Don Penney <don.penney@windriver.com>
flake8 3.6.0 fails on ubuntu-focal zuul machines running python3.8
with the following error:
AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'
The update removes the version constraint to use newer flake8. This
also ignores new warnings/errors, which should be addressed in a
future update to remove the ignores
Change-Id: Id22fb14e2cce76c2f4f5234abb3be4db68c70555
Partial-Bug: 1895054
Signed-off-by: Steven Webster <steven.webster@windriver.com>
This change imposes the upper constraint in tox to protect from
future releases causing random breakage.
Ex: A new version of python-libvirt was released Jan 23 2020
which will not install on python2.
This change also enables the python3 target for pylint which will
allow the upper constraint to be changed to a more recent version
when all the tox files are aligned.
Change-Id: I9056778085d32b3401df60c20d67cff0a21dfe97
Story: 2004515
Task: 38496
Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
'containers'
List of relocated subdirectories:
kubernetes/registry-token-server
Story: 2006166
Task: 35687
Depends-On: I665dc7fabbfffc798ad57843eb74dca16e7647a3
Depends-On: Ibdae0a338a1af493ac522757b61bbd6df1da941e
Change-Id: I7f1c1184e8dfeff1740b695adb71b8becaa4e7b1
Signed-off-by: Scott Little <scott.little@windriver.com>
The new version of libvirt-python was released on July 3rd
and may be triggering an issue when installing for pylint jobs.
The fix is to add bindep target for the pkgconfig
and libvirt-devel components.
Change-Id: Ib2c0a953bf8be127aa8d6ce4bd74d7f2f5ceccae
Closes-Bug: #1835457
Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
Flake8 currently ignores the following errors:
B301: Python3 does not include ".iter*" methods on dictionaries
H237: Module is removed in python3
W191: Indentation contains tabs
Which do not appear currently in the repo. Enable them
so that they do not get introduced
Change-Id: I0321ee40f869c03321a1cbd67c45056206437f6b
Story: 2004515
Task: 30076
Signed-off-by: Eric Barrett <eric.barrett@windriver.com>
The pylint tox setup failures are because keyring 19.x does not
work with python2.7.
This is now imposed in the tox.ini file.
Closes-Bug: 1828241
Change-Id: Ib6219a508ef843358b46b2f49c4da28d1a8bbec8
Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
Flake8 currently ignores the following errors:
H401: docstring should not start with a space
H404: multi line docstring should start without a leading new line
H405: multi line docstring summary not separated with an empty line
Enable them for more consistent formatting of docstrings
Change-Id: I385e28e9c6eca3c02a3def51ff64b00b7a63a853
Story: 2004515
Task: 30076
Signed-off-by: Eric Barrett <eric.barrett@windriver.com>
Flake8 currently ignores the following errors:
E302: expected 2 blank lines[COMMA] found 1
E303: too many blank lines
E305: expected 2 blank lines after class or function definition, found 1
Change-Id: Idfb00e530967f1a345bc2e263ad77597f83cc5d3
Story: 2004515
Task: 30076
Signed-off-by: Eric Barrett <eric.barrett@windriver.com>
Flake8 currently ignores the following Errors:
E121: continuation line under-indented for hanging indent
E123: closing bracket doesn't match indentation of opening bracket
E124: closing bracket doesn't match visual indentation
E125: continuation line with same indent as next logical line
E126: continuation line over-indented for hanging indent
E127: continuation line over-indented for visual indent
E128: continuation line under-indented for visual indent
Enable them for more consistent formatting of code
Change-Id: I415d4824a1f335ba3fceb488b0ae60b9861a036a
Story: 2004515
Task: 30076
Signed-off-by: Eric Barrett <eric.barrett@windriver.com>
A new bugbear was released which broke zuul.
This commit locks bugbear at that release and
suppresses those two new error types.
Later commits may clean those up, however
it is more likely bugbear will be removed and
a different flake8 and hacking will be used.
Story: 2004515
Task: 30260
Change-Id: I213163b3043b439daccd1f9c9d6db846e1248dae
Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
Flake8 currently ignores ambiguous variable name error (E741)
Enable it for more thorough testing of code
Change-Id: I752b4a2a380ee086882260981c448bd7217de003
Story: 2004515
Task: 30076
Signed-off-by: Eric Barrett <eric.barrett@windriver.com>
Flake8 currently ignores a number of whitespace related errors:
E201: whitespace after '['
E202: whitespace before '}'
E203: whitespace before ':'
E211: whitespace before '('
E221: multiple spaces before operator
E222: multiple spaces after operator
E225: missing whitespace around operator
E226: missing whitespace around arithmetic operator
E231: missing whitespace after ','
E251: unexpected spaces around keyword / parameter equals
E261: at least two spaces before inline comment
Enable them for more thorough testing of code
Change-Id: Id03f36070b8f16694a12f4d36858680b6e00d530
Story: 2004515
Task: 30076
Signed-off-by: Eric Barrett <eric.barrett@windriver.com>
Flake8 currently ignores local variable assigned to but unused error (F841)
Enable F841 for more thorough testing of code
Change-Id: I5a9002dde77773d5e96531e2d4fee3c55264e0fd
Story: 2004515
Task: 30076
Signed-off-by: Eric Barrett <eric.barrett@windriver.com>
Flake8 currently ignores 'BaseException.message' removed in python3
Enable B306 for more thorough testing of code
Change-Id: I9fbb01e8f61d679f4e611324efca6017c3b210e8
Story: 2004515
Task: 30076
Signed-off-by: Eric Barrett <eric.barrett@windriver.com>
Flake8 currently ignores comparison to None should be 'if cond is None'
Enable E711 for more thorough testing of code
Change-Id: I608cceff2eeb87c116bccddac26e3c869e5d57df
Story: 2004515
Task: 30076
Signed-off-by: Eric Barrett <eric.barrett@windriver.com>
Flake8 currently ignores python3.x incompatible use of print operator
Enable H233 for more thorough testing of code
Change-Id: I77d6bdb4f792a832f04bbf8bd73a9ae3532633ff
Story: 2004515
Task: 30076
Signed-off-by: Eric Barrett <eric.barrett@windriver.com>
Flake8 currently ignores syntax errors
Change python2 style print statements to python3 compatible style
Change in print statements results in new errors discovered by flake8
Fix B006: Do not use mutable data structures for argument defaults error
Fix F821: undefined name 'hashlib' error
Enable syntax errors (E999) for more thorough testing of code
Change-Id: Id8849e4e117ddd1fd50309415466b593d13e7456
Story: 2004515
Task: 30076
Signed-off-by: Eric Barrett <eric.barrett@windriver.com>
Flake8 currently ignores indentation that contains mixed spaces and tabs
Enable it for more thorough testing of code
Story: 2004515
Task: 30076
Change-Id: I268f1c5695bf913daee7497191e6f9546d51e6a0
Signed-off-by: Eric Barrett <eric.barrett@windriver.com>
The failing pylint warnings and errors are currently
suppressed. They will be fixed by subsequent commits.
Story: 2004515
Task: 28791
Change-Id: I93a89554bf2dfbd9d1cbd96728a7663c408a79b1
Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
use proper absolute path to import modules
remove ignore case 'H301: one import per line'
Story: 2002909
Task: 24886
Change-Id: I1d72e68ead64492ff0c74f8c1bf1b460b573bc1e
Signed-off-by: Sun Austin <austin.sun@intel.com>
At this point this only installs platform_utils
Depends-On: https://review.openstack.org/613973
Change-Id: I5cfb89592b25d60adf717e97c1859af989c08d2f
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
Bashate was not always detecting:
E004 File did not end with a newline
unless the last file processed by bashate had the violation.
This meant that zuul jobs would randomly fail.
The fix is run individually (-n 1)
Change-Id: I7934c3da82adb450fd1ba5f2630591369df8b828
Closes-Bug: 1800865
Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
The new flake8 version 3.6.0 introduces new warnings that cause
the check and gate jobs to fail. Locking down the flake8 version
to avoid these surprises in the future. We can later increment
the flake8 version and fix the new warnings in a controlled
manner.
Change-Id: Ie3fe4ccbb3acde158482f3207bbae655f32ae3d0
Partial-Bug: 1799721
Signed-off-by: Bart Wensley <barton.wensley@windriver.com>
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: Ibc8914bb48e793cbe053792bfef8b9c53758112b
- Convert from pep8 to flake8.
- Add in hacking and bugbear plugins to flake8
- Suppress any flake8 errors that fail.
Future tasks will be created to cleanup and
fix the suppressed error codes.
Story: 2002803
Task: 26884
Change-Id: I8bf0978f27be1cc1108d21a002e650c5072b4c67
Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
Baseline changes to comply with Release Notes Management
based in Reno [0]:
* Use build-openstack-releasenotes job for release notes
(We can't use the OpenStack releasenotes template as it includes
publish jobs, stx needs its own)
* Add newnote tox environment as convenience for creating new release
notes, re-using the releasenotes venv.
[0] https://docs.openstack.org/reno/latest/
Story: 2003101
Task: 26719
Change-Id: If4f8833fb4d3539ba47ce3014d4d3bbae409c278
Signed-off-by: Abraham Arce <abraham.arce.moreno@intel.com>
Fix below linters errors
E010 The "do" should be on same line as for
E010 The "do" should be on same line as while
E011 Then keyword is not on same line as if or elif keyword
E020 Function declaration not in format ^function name {$
Ignore:
E041 Arithmetic expansion using $[ is deprecated for $((
E042 local declaration hides errors
E043 Arithmetic compound has inconsistent return semantics
E044 Use [[ for non-POSIX comparisions
Story: 2003366
Task: 24423
Change-Id: I8b6b72e702d3e89d1813772d6bf16819e28e818c
Signed-off-by: Martin Chen <haochuan.z.chen@intel.com>
Leonardo Fagundes Luz Serrano