starlingx
/
root
Code Issues Proposed changes

build-pkg pkg-name of std pkg causes rt build failure 

Brief Description
-----------------
Designer issues 'build-pkg pkg-name' where pkg-name is only valid for
std builds.

Expected result is that only 'std' build is executed on the named
package.
What is observed is that aftes a successful std build, an 'rt' build is
executed with an invalid package list causing a failure.

The package is built correctly, but command returns 1.
This breaks scripts that test build-pkgs return code.

Problem
-------
find_targets returned $EMPTY_LIST rather than $EMPTY_TARGETS as expected.

Solution
--------
find_targets must return $EMPTY_TARGETS when no targets are found for
the build type.

Closes-Bug: 1794542
Change-Id: I3d21bb793b1fc9637b16a08fdfcd2fd998742bfb
Signed-off-by: Scott Little <scott.little@windriver.com>
This commit is contained in:
Scott Little 2018-09-26 11:06:40 -04:00
parent 717da7b675
commit 91f3b6f899
2 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
build-tools/build-pkgs-parallel
View File

@ -174,7 +174,7 @@ find_targets () {
local x=""
local name=""
local path=""
local RESULT=" "
local RESULT="$EMPTY_TARGETS"
local FOUND=0
for d in $GIT_LIST; do
@ -234,11 +234,7 @@ find_targets () {
fi
done
if [ "$RESULT" == " " ]; then
echo "$EMPTY_LIST"
else
echo "$RESULT"
fi
echo "$RESULT"
return 0
}

8
build-tools/build-pkgs-serial
View File

@ -174,7 +174,7 @@ find_targets () {
local x=""
local name=""
local path=""
local RESULT=" "
local RESULT="$EMPTY_TARGETS"
local FOUND=0
for d in $GIT_LIST; do
@ -234,11 +234,7 @@ find_targets () {
fi
done
if [ "$RESULT" == " " ]; then
echo "$EMPTY_LIST"
else
echo "$RESULT"
fi
echo "$RESULT"
return 0
}