Update patch set 2
Patch Set 2: (2 comments) Patch-set: 2 Reviewer: Gerrit User 15405 <15405@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Verified=0
This commit is contained in:
parent
6bbb228474
commit
5e6fd20a13
|
@ -0,0 +1,50 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_07f1f96a",
|
||||
"filename": "sysinv/sysinv/sysinv/sysinv/cmd/agent.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 33,
|
||||
"author": {
|
||||
"id": 15405
|
||||
},
|
||||
"writtenOn": "2018-06-29T04:06:21Z",
|
||||
"side": 1,
|
||||
"message": "Why not enable coverage from the tests instead of instrument the code directly?\n\nOr, is this change intended to measure the coverage from tests that interacts with these programs through command line execution?",
|
||||
"range": {
|
||||
"startLine": 33,
|
||||
"startChar": 0,
|
||||
"endLine": 33,
|
||||
"endChar": 34
|
||||
},
|
||||
"revId": "87a0836518ae5eae04f435ee26846514787faa3a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_a757e55a",
|
||||
"filename": "sysinv/sysinv/sysinv/sysinv/sanity_coverage.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 25,
|
||||
"author": {
|
||||
"id": 15405
|
||||
},
|
||||
"writtenOn": "2018-06-29T04:06:21Z",
|
||||
"side": 1,
|
||||
"message": "Which component is responsible to manage this flag file?",
|
||||
"range": {
|
||||
"startLine": 25,
|
||||
"startChar": 13,
|
||||
"endLine": 25,
|
||||
"endChar": 38
|
||||
},
|
||||
"revId": "87a0836518ae5eae04f435ee26846514787faa3a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue