starlingx
/
config
Code Issues Proposed changes

Fix positional argument error when running the 76 script. 

A new mandatory argument was added to the registry_image.list
method in the cgts sysinv client breaking the contract on
76-remove-armada-if-unused.py thus resulting in a TypeError
exception.

This commit adds the missing parameter and fixes the error.

Test Plan:
PASS Build pkgs and build image
PASS Upgrade SX stx-8 -> master
PASS Armada removed when there are no Armada apps

Closes-Bug: 2047643

Change-Id: I16a8cc4ed6c12751fc3f90c7c12499914cf6aa52
Signed-off-by: David Bastos <david.barbosabastos@windriver.com>
This commit is contained in:
dbarbosa 2023-12-27 11:53:50 -03:00
parent 4134359426
commit 77f2c9ce3d
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
controllerconfig/controllerconfig/upgrade-scripts/76-remove-armada-if-unused.py
View File

@ -312,7 +312,8 @@ def remove_docker_images():
tiller_image = None
# Get image names
image_list = client.sysinv.registry_image.list()
filter_out_untagged = False
image_list = client.sysinv.registry_image.list(int(filter_out_untagged))
if not image_list:
LOG.warning("Failed to remove armada docker image.")
return False