diff --git a/9fc2be9eee926203734dba76feb2783d2aa6d2bd b/9fc2be9eee926203734dba76feb2783d2aa6d2bd new file mode 100644 index 0000000000..1f66fff563 --- /dev/null +++ b/9fc2be9eee926203734dba76feb2783d2aa6d2bd @@ -0,0 +1,90 @@ +{ + "comments": [ + { + "unresolved": true, + "key": { + "uuid": "70c88b07_7beeb719", + "filename": "/COMMIT_MSG", + "patchSetId": 6 + }, + "lineNbr": 20, + "author": { + "id": 8768 + }, + "writtenOn": "2024-04-25T22:26:45Z", + "side": 1, + "message": "this seems like a pretty generic keyword to be used for the specific task of querying K8s version compatibility. Maybe something like \"sysinv-app query-k8s-version\" or \"sysinv-app query k8s-version\" would give more leeway in case we wanted to support other queries in the future?", + "range": { + "startLine": 20, + "startChar": 11, + "endLine": 20, + "endChar": 16 + }, + "revId": "9fc2be9eee926203734dba76feb2783d2aa6d2bd", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": false, + "key": { + "uuid": "2ea85a0d_493b5607", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 6 + }, + "lineNbr": 0, + "author": { + "id": 8768 + }, + "writtenOn": "2024-04-25T22:26:45Z", + "side": 1, + "message": "Generally looks okay, had a few comments. Other cores can feel free to merge if they think I\u0027m being too picky.", + "revId": "9fc2be9eee926203734dba76feb2783d2aa6d2bd", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "1f32c91b_767b7aa3", + "filename": "sysinv/sysinv/sysinv/sysinv/cmd/applications.py", + "patchSetId": 6 + }, + "lineNbr": 93, + "author": { + "id": 8768 + }, + "writtenOn": "2024-04-25T22:26:45Z", + "side": 1, + "message": "double comma intentional?", + "range": { + "startLine": 93, + "startChar": 42, + "endLine": 93, + "endChar": 44 + }, + "revId": "9fc2be9eee926203734dba76feb2783d2aa6d2bd", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "35ed1aa1_5fefcbda", + "filename": "sysinv/sysinv/sysinv/sysinv/cmd/applications.py", + "patchSetId": 6 + }, + "lineNbr": 162, + "author": { + "id": 8768 + }, + "writtenOn": "2024-04-25T22:26:45Z", + "side": 1, + "message": "can be simplified as:\n\ninclude_path \u003d \u0027--include-path\u0027 in sys.argv\n\nbut I think either one of those would also result in include_path being True if sys.argv includes something like \"--include-path-foo\".", + "range": { + "startLine": 162, + "startChar": 8, + "endLine": 162, + "endChar": 70 + }, + "revId": "9fc2be9eee926203734dba76feb2783d2aa6d2bd", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + } + ] +} \ No newline at end of file