starlingx
/
config
Code Issues Proposed changes

Update patch set 16 

Patch Set 16: Code-Review+1

(3 comments)

Patch-set: 16
Reviewer: Gerrit User 28466 <28466@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, feb8ad29e03cd4b0ce89ed20016a719863e47e4c
Attention: {"person_ident":"Gerrit User 28466 \u003c28466@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28466\u003e replied on the change"}
This commit is contained in:
Gerrit User 28466 2024-05-02 20:15:20 +00:00 committed by Gerrit Code Review
parent 601e5b4452
commit 861bd3ef79
2 changed files with 69 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
b377411c15a909f9a8a28fbd129ea3cbff0fe8f3 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "752e9d81_0547c18f",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 16
},
"lineNbr": 0,
"author": {
"id": 28466
},
"writtenOn": "2024-05-02T20:15:20Z",
"side": 1,
"message": "please address Eric\u0027s comments.",
"revId": "b377411c15a909f9a8a28fbd129ea3cbff0fe8f3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

48
eac208e1b538e2de2d10fa258bc9097c747f0ac8
View File

@ -86,6 +86,30 @@
"revId": "eac208e1b538e2de2d10fa258bc9097c747f0ac8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5c8fb487_1c0e0fe0",
"filename": "sysinv/ipsec-auth/files/ipsec-config",
"patchSetId": 13
},
"lineNbr": 90,
"author": {
"id": 28466
},
"writtenOn": "2024-05-02T20:15:20Z",
"side": 1,
"message": "Thanks for the update.",
"parentUuid": "496c64a8_806bbcb6",
"range": {
"startLine": 84,
"startChar": 0,
"endLine": 90,
"endChar": 6
},
"revId": "eac208e1b538e2de2d10fa258bc9097c747f0ac8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -155,6 +179,30 @@
"revId": "eac208e1b538e2de2d10fa258bc9097c747f0ac8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "33e7bd67_42859f0e",
"filename": "sysinv/ipsec-auth/files/ipsec-config",
"patchSetId": 13
},
"lineNbr": 118,
"author": {
"id": 28466
},
"writtenOn": "2024-05-02T20:15:20Z",
"side": 1,
"message": "Thanks for the update. I think it is good now.",
"parentUuid": "7aab53ef_d818def4",
"range": {
"startLine": 115,
"startChar": 0,
"endLine": 118,
"endChar": 6
},
"revId": "eac208e1b538e2de2d10fa258bc9097c747f0ac8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {