starlingx
/
config
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review+1

(2 comments)

Patch-set: 3
Reviewer: Gerrit User 28464 <28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, 1d981bc133cac589ef41666433f2f41ca0971c0b
Attention: {"person_ident":"Gerrit User 32933 \u003c32933@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28464\u003e replied on the change"}
This commit is contained in:
Gerrit User 28464 2024-05-03 13:29:26 +00:00 committed by Gerrit Code Review
parent 5cea029e32
commit d509dd5341
1 changed files with 50 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
ebeadb53662f087a356d8eb057ec79b96fc6a9a8 Normal file
View File

@ -0,0 +1,50 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "047ec786_7043c1e7",
"filename": "sysinv/sysinv/sysinv/sysinv/common/utils.py",
"patchSetId": 3
},
"lineNbr": 3800,
"author": {
"id": 28464
},
"writtenOn": "2024-05-03T13:29:26Z",
"side": 1,
"message": "nit: Don\u0027t think we should be using \u0027we\u0027 in a log. Should not be using first person pronouns in logs.",
"range": {
"startLine": 3800,
"startChar": 23,
"endLine": 3800,
"endChar": 26
},
"revId": "ebeadb53662f087a356d8eb057ec79b96fc6a9a8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a4b92abe_1413a556",
"filename": "sysinv/sysinv/sysinv/sysinv/puppet/base.py",
"patchSetId": 3
},
"lineNbr": 197,
"author": {
"id": 28464
},
"writtenOn": "2024-05-03T13:29:26Z",
"side": 1,
"message": "If address is None then is there a chance that address_name might be a bad index ? and should address be checked before assigning it here.",
"range": {
"startLine": 197,
"startChar": 22,
"endLine": 197,
"endChar": 34
},
"revId": "ebeadb53662f087a356d8eb057ec79b96fc6a9a8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}