config/49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "ec71405e_6622d7f8",
        "filename": "/COMMIT_MSG",
        "patchSetId": 3
      },
      "lineNbr": 40,
      "author": {
        "id": 9926
      },
      "writtenOn": "2024-05-09T13:26:41Z",
      "side": 1,
      "message": "recommend to verify\n\u0027system service-parameter-add\u0027\n\u0027system service-parameter-modify \u0027\n\u0027system service-parameter-delete \u0027",
      "range": {
        "startLine": 40,
        "startChar": 15,
        "endLine": 40,
        "endChar": 20
      },
      "revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "c34eff5b_feb81872",
        "filename": "/COMMIT_MSG",
        "patchSetId": 3
      },
      "lineNbr": 40,
      "author": {
        "id": 35741
      },
      "writtenOn": "2024-05-09T14:38:23Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "ec71405e_6622d7f8",
      "range": {
        "startLine": 40,
        "startChar": 15,
        "endLine": 40,
        "endChar": 20
      },
      "revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "6d42533e_6a753c6f",
        "filename": "/COMMIT_MSG",
        "patchSetId": 3
      },
      "lineNbr": 42,
      "author": {
        "id": 9926
      },
      "writtenOn": "2024-05-09T13:26:41Z",
      "side": 1,
      "message": "should verify sysinv_api_workers cannot be over the number of cpus with Platform function (as in \u0027system host-cpu-list \u0027)",
      "revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "0a0ecc44_4cac967c",
        "filename": "/COMMIT_MSG",
        "patchSetId": 3
      },
      "lineNbr": 42,
      "author": {
        "id": 35741
      },
      "writtenOn": "2024-05-09T15:00:02Z",
      "side": 1,
      "message": "I don\u0027t think we should limit it just to platform cores . Aren\u0027t we giving the customer the ability to tune these workers so that they can install tons and tons of subclouds ?",
      "parentUuid": "6d42533e_6a753c6f",
      "revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "e197dc74_81501fbd",
        "filename": "/COMMIT_MSG",
        "patchSetId": 3
      },
      "lineNbr": 44,
      "author": {
        "id": 9926
      },
      "writtenOn": "2024-05-09T13:26:41Z",
      "side": 1,
      "message": "needs Story/Task\n\ne.g. in https://storyboard.openstack.org/#!/story/2011106",
      "revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "f90882c1_134b58b3",
        "filename": "/COMMIT_MSG",
        "patchSetId": 3
      },
      "lineNbr": 44,
      "author": {
        "id": 35741
      },
      "writtenOn": "2024-05-09T14:38:23Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "e197dc74_81501fbd",
      "revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "02f91f19_7e2bb5dd",
        "filename": "sysinv/cgts-client/cgts-client/cgtsclient/tests/v1/test_service_parameter_shell.py",
        "patchSetId": 3
      },
      "lineNbr": 15,
      "author": {
        "id": 35148
      },
      "writtenOn": "2024-05-09T14:11:46Z",
      "side": 1,
      "message": "Missing tests for invalid user input.",
      "range": {
        "startLine": 15,
        "startChar": 0,
        "endLine": 15,
        "endChar": 24
      },
      "revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "18c00e8e_7bad462d",
        "filename": "sysinv/cgts-client/cgts-client/cgtsclient/tests/v1/test_service_parameter_shell.py",
        "patchSetId": 3
      },
      "lineNbr": 15,
      "author": {
        "id": 35741
      },
      "writtenOn": "2024-05-09T15:00:02Z",
      "side": 1,
      "message": "Validation seems to be happening either at the cgts-client or at the sysinv_api v1 handlers. The actual service_parameter_shell.py isn\u0027t doing much validation on input",
      "parentUuid": "02f91f19_7e2bb5dd",
      "range": {
        "startLine": 15,
        "startChar": 0,
        "endLine": 15,
        "endChar": 24
      },
      "revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "b6c3c22e_14329500",
        "filename": "sysinv/sysinv/sysinv/sysinv/common/service_parameter.py",
        "patchSetId": 3
      },
      "lineNbr": 613,
      "author": {
        "id": 9926
      },
      "writtenOn": "2024-05-09T13:26:41Z",
      "side": 1,
      "message": "should be based on number of cpus with \u0027Platform\u0027 function",
      "revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "a9bbb6f6_1c63fff4",
        "filename": "sysinv/sysinv/sysinv/sysinv/common/service_parameter.py",
        "patchSetId": 3
      },
      "lineNbr": 613,
      "author": {
        "id": 35741
      },
      "writtenOn": "2024-05-09T15:00:02Z",
      "side": 1,
      "message": "same comment as above . I think we should allow up to all physical cores not just platform cores",
      "parentUuid": "b6c3c22e_14329500",
      "revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "f1064437_5178da8f",
        "filename": "sysinv/sysinv/sysinv/sysinv/common/service_parameter.py",
        "patchSetId": 3
      },
      "lineNbr": 614,
      "author": {
        "id": 35148
      },
      "writtenOn": "2024-05-09T14:11:46Z",
      "side": 1,
      "message": "More of a todo.  Should there also be a min_sysinv_api_workers service-parameter to set this?",
      "range": {
        "startLine": 614,
        "startChar": 4,
        "endLine": 614,
        "endChar": 19
      },
      "revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "0a9943ce_21bd0fd4",
        "filename": "sysinv/sysinv/sysinv/sysinv/common/service_parameter.py",
        "patchSetId": 3
      },
      "lineNbr": 614,
      "author": {
        "id": 35741
      },
      "writtenOn": "2024-05-09T14:38:23Z",
      "side": 1,
      "message": "well you need at least 1 worker to process a sysinv api request",
      "parentUuid": "f1064437_5178da8f",
      "range": {
        "startLine": 614,
        "startChar": 4,
        "endLine": 614,
        "endChar": 19
      },
      "revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "9c18513d_6abe9253",
        "filename": "sysinv/sysinv/sysinv/sysinv/common/service_parameter.py",
        "patchSetId": 3
      },
      "lineNbr": 614,
      "author": {
        "id": 35148
      },
      "writtenOn": "2024-05-09T14:47:34Z",
      "side": 1,
      "message": "I was thinking of something along the lines of: min(max(value, MIN_WORKERS), MAX_WORKERS), where value\u003d1 and MIN_WORKERS\u003d2.\n\nTo let you do things like 2 workers on 1 core.",
      "parentUuid": "0a9943ce_21bd0fd4",
      "range": {
        "startLine": 614,
        "startChar": 4,
        "endLine": 614,
        "endChar": 19
      },
      "revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "e714729f_5466cef7",
        "filename": "sysinv/sysinv/sysinv/sysinv/common/service_parameter.py",
        "patchSetId": 3
      },
      "lineNbr": 614,
      "author": {
        "id": 35741
      },
      "writtenOn": "2024-05-09T15:00:02Z",
      "side": 1,
      "message": "Acknowledged",
      "parentUuid": "0a9943ce_21bd0fd4",
      "range": {
        "startLine": 614,
        "startChar": 4,
        "endLine": 614,
        "endChar": 19
      },
      "revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "f34da433_8b7c3721",
        "filename": "sysinv/sysinv/sysinv/sysinv/common/utils.py",
        "patchSetId": 3
      },
      "lineNbr": 1034,
      "author": {
        "id": 9926
      },
      "writtenOn": "2024-05-09T13:26:41Z",
      "side": 1,
      "message": "this should accept the minimum value from each controller rather than adding all controllers.\nand should be based on only cpus with PLATFORM_FUNCTION (since on AIO, not all cpus are PLATFORM_FUNCTION )",
      "revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "db1c587c_73a3796a",
        "filename": "sysinv/sysinv/sysinv/sysinv/common/utils.py",
        "patchSetId": 3
      },
      "lineNbr": 1034,
      "author": {
        "id": 35741
      },
      "writtenOn": "2024-05-09T15:00:02Z",
      "side": 1,
      "message": "same comment as above . I think we should allow up to all physical cores not just platform cores",
      "parentUuid": "f34da433_8b7c3721",
      "revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}