config/1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "419c7f4e_3bf57ec8",
        "filename": "controllerconfig/controllerconfig/upgrade-scripts/08-populate-ihost-sw-version-field.py",
        "patchSetId": 10
      },
      "lineNbr": 45,
      "author": {
        "id": 9926
      },
      "writtenOn": "2024-04-25T12:50:04Z",
      "side": 1,
      "message": "is to_release condition required ?",
      "range": {
        "startLine": 44,
        "startChar": 55,
        "endLine": 45,
        "endChar": 33
      },
      "revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "b1a384b8_969130d6",
        "filename": "controllerconfig/controllerconfig/upgrade-scripts/08-populate-ihost-sw-version-field.py",
        "patchSetId": 10
      },
      "lineNbr": 45,
      "author": {
        "id": 33684
      },
      "writtenOn": "2024-04-26T06:16:00Z",
      "side": 1,
      "message": "No, it\u0027s not. Thanks for review!",
      "parentUuid": "419c7f4e_3bf57ec8",
      "range": {
        "startLine": 44,
        "startChar": 55,
        "endLine": 45,
        "endChar": 33
      },
      "revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "4bbd76ff_6812e688",
        "filename": "sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/migrate_repo/versions/137_add_host_sw_version.py",
        "patchSetId": 10
      },
      "lineNbr": 15,
      "author": {
        "id": 9926
      },
      "writtenOn": "2024-04-25T12:50:04Z",
      "side": 1,
      "message": "this could be reduced in size , 128 should be sufficient?",
      "range": {
        "startLine": 15,
        "startChar": 57,
        "endLine": 15,
        "endChar": 60
      },
      "revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "7dd04d51_d486cf7c",
        "filename": "sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/migrate_repo/versions/137_add_host_sw_version.py",
        "patchSetId": 10
      },
      "lineNbr": 15,
      "author": {
        "id": 33390
      },
      "writtenOn": "2024-04-25T14:48:38Z",
      "side": 1,
      "message": "Even less, sw_version show be MM.mm.pp if I\u0027m not mistaken, so maybe 16 is enough.",
      "parentUuid": "4bbd76ff_6812e688",
      "range": {
        "startLine": 15,
        "startChar": 57,
        "endLine": 15,
        "endChar": 60
      },
      "revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "17d4dafe_3f05967e",
        "filename": "sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/migrate_repo/versions/137_add_host_sw_version.py",
        "patchSetId": 10
      },
      "lineNbr": 15,
      "author": {
        "id": 33684
      },
      "writtenOn": "2024-04-26T06:16:00Z",
      "side": 1,
      "message": "yes, it could.",
      "parentUuid": "4bbd76ff_6812e688",
      "range": {
        "startLine": 15,
        "startChar": 57,
        "endLine": 15,
        "endChar": 60
      },
      "revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "2e3a7bdf_380793b4",
        "filename": "sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/models.py",
        "patchSetId": 10
      },
      "lineNbr": 200,
      "author": {
        "id": 33390
      },
      "writtenOn": "2024-04-25T14:48:38Z",
      "side": 1,
      "message": "Same comment from John about the column size applies here.",
      "range": {
        "startLine": 200,
        "startChar": 24,
        "endLine": 200,
        "endChar": 35
      },
      "revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "c6dbc9e2_f9db1941",
        "filename": "sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/models.py",
        "patchSetId": 10
      },
      "lineNbr": 200,
      "author": {
        "id": 33684
      },
      "writtenOn": "2024-04-26T06:16:00Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "2e3a7bdf_380793b4",
      "range": {
        "startLine": 200,
        "startChar": 24,
        "endLine": 200,
        "endChar": 35
      },
      "revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "8c01fac7_7f2f365b",
        "filename": "sysinv/sysinv/sysinv/sysinv/tests/conductor/test_manager.py",
        "patchSetId": 10
      },
      "lineNbr": 638,
      "author": {
        "id": 9926
      },
      "writtenOn": "2024-04-25T12:50:04Z",
      "side": 1,
      "message": "nit: future version format  MM.mm.pp\nis this only to represent MM.mm ?",
      "range": {
        "startLine": 638,
        "startChar": 36,
        "endLine": 638,
        "endChar": 41
      },
      "revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "92e45b52_1f42e695",
        "filename": "sysinv/sysinv/sysinv/sysinv/tests/conductor/test_manager.py",
        "patchSetId": 10
      },
      "lineNbr": 638,
      "author": {
        "id": 33684
      },
      "writtenOn": "2024-04-26T06:16:00Z",
      "side": 1,
      "message": "No, it\u0027s not. I\u0027ve set as 0.0 to be as is today but with size of 128 it could be MM.mm.pp as well.",
      "parentUuid": "8c01fac7_7f2f365b",
      "range": {
        "startLine": 638,
        "startChar": 36,
        "endLine": 638,
        "endChar": 41
      },
      "revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}