config/6b1fb029382983961207f64f778e5460debf9d8a

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "7399ec2f_fbaa5db8",
        "filename": "sysinv/ipsec-auth/files/ipsec-config",
        "patchSetId": 3
      },
      "lineNbr": 128,
      "author": {
        "id": 28676
      },
      "writtenOn": "2024-04-24T14:07:34Z",
      "side": 1,
      "message": "Maybe remove these comment, and just say:\n\nWhen the service starts after the controller becomes active, symlink the active version of the configuration file to swanctl.conf, reload the configuration and terminate existing SAs so that new ones obedient to the updated config are created.\n\nWhen the service stops after the controller becomes standby, symlink the standby version of the configuration file to swanctl.conf, reload the configuration and terminate existing SAs so that new ones obedient to the updated config are created.",
      "range": {
        "startLine": 122,
        "startChar": 1,
        "endLine": 128,
        "endChar": 32
      },
      "revId": "6b1fb029382983961207f64f778e5460debf9d8a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "d021b807_2e6ea48a",
        "filename": "sysinv/ipsec-auth/files/ipsec-config",
        "patchSetId": 3
      },
      "lineNbr": 128,
      "author": {
        "id": 35603
      },
      "writtenOn": "2024-04-24T16:03:38Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "7399ec2f_fbaa5db8",
      "range": {
        "startLine": 122,
        "startChar": 1,
        "endLine": 128,
        "endChar": 32
      },
      "revId": "6b1fb029382983961207f64f778e5460debf9d8a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "5cc0dd97_7840da02",
        "filename": "sysinv/ipsec-auth/files/ipsec-config",
        "patchSetId": 3
      },
      "lineNbr": 140,
      "author": {
        "id": 28676
      },
      "writtenOn": "2024-04-24T14:07:34Z",
      "side": 1,
      "message": "Alignment is wrong. I think I use tab for alignment in my original patch.",
      "range": {
        "startLine": 136,
        "startChar": 1,
        "endLine": 140,
        "endChar": 3
      },
      "revId": "6b1fb029382983961207f64f778e5460debf9d8a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "5a2d8f7a_92082ab7",
        "filename": "sysinv/ipsec-auth/files/ipsec-config",
        "patchSetId": 3
      },
      "lineNbr": 140,
      "author": {
        "id": 35603
      },
      "writtenOn": "2024-04-24T16:03:38Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "5cc0dd97_7840da02",
      "range": {
        "startLine": 136,
        "startChar": 1,
        "endLine": 140,
        "endChar": 3
      },
      "revId": "6b1fb029382983961207f64f778e5460debf9d8a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "a4677e8f_6452981f",
        "filename": "sysinv/ipsec-auth/files/ipsec-config",
        "patchSetId": 3
      },
      "lineNbr": 148,
      "author": {
        "id": 28676
      },
      "writtenOn": "2024-04-24T14:07:34Z",
      "side": 1,
      "message": "This is wrong, we need to terminate existing SAs for both start and stop, so new SAs obedient to the updated configuration will be created.",
      "range": {
        "startLine": 142,
        "startChar": 0,
        "endLine": 148,
        "endChar": 6
      },
      "revId": "6b1fb029382983961207f64f778e5460debf9d8a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "7f037130_7690297f",
        "filename": "sysinv/ipsec-auth/files/ipsec-config",
        "patchSetId": 3
      },
      "lineNbr": 148,
      "author": {
        "id": 35603
      },
      "writtenOn": "2024-04-24T16:03:38Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "a4677e8f_6452981f",
      "range": {
        "startLine": 142,
        "startChar": 0,
        "endLine": 148,
        "endChar": 6
      },
      "revId": "6b1fb029382983961207f64f778e5460debf9d8a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "52aff8a4_9549c473",
        "filename": "sysinv/ipsec-auth/files/ipsec-config",
        "patchSetId": 3
      },
      "lineNbr": 165,
      "author": {
        "id": 28676
      },
      "writtenOn": "2024-04-24T14:07:34Z",
      "side": 1,
      "message": "update_ipsec_config currently doesn\u0027t return OCF_SUCCESS or OCF_NOT_RUNNING, it return 0 or 1.",
      "range": {
        "startLine": 165,
        "startChar": 0,
        "endLine": 165,
        "endChar": 40
      },
      "revId": "6b1fb029382983961207f64f778e5460debf9d8a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "f2fc0485_7834eae8",
        "filename": "sysinv/ipsec-auth/files/ipsec-config",
        "patchSetId": 3
      },
      "lineNbr": 165,
      "author": {
        "id": 35603
      },
      "writtenOn": "2024-04-24T16:03:38Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "52aff8a4_9549c473",
      "range": {
        "startLine": 165,
        "startChar": 0,
        "endLine": 165,
        "endChar": 40
      },
      "revId": "6b1fb029382983961207f64f778e5460debf9d8a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "dae371ec_3d07f82c",
        "filename": "sysinv/ipsec-auth/files/ipsec-config",
        "patchSetId": 3
      },
      "lineNbr": 186,
      "author": {
        "id": 28676
      },
      "writtenOn": "2024-04-24T14:07:34Z",
      "side": 1,
      "message": "update_ipsec_config currently doesn\u0027t return OCF_SUCCESS or OCF_NOT_RUNNING, it return 0 or 1.",
      "range": {
        "startLine": 184,
        "startChar": 1,
        "endLine": 186,
        "endChar": 40
      },
      "revId": "6b1fb029382983961207f64f778e5460debf9d8a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "dc8a17c6_2971c7ae",
        "filename": "sysinv/ipsec-auth/files/ipsec-config",
        "patchSetId": 3
      },
      "lineNbr": 186,
      "author": {
        "id": 35603
      },
      "writtenOn": "2024-04-24T16:03:38Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "dae371ec_3d07f82c",
      "range": {
        "startLine": 184,
        "startChar": 1,
        "endLine": 186,
        "endChar": 40
      },
      "revId": "6b1fb029382983961207f64f778e5460debf9d8a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "8adceae0_38a4d845",
        "filename": "sysinv/ipsec-auth/files/ipsec-config",
        "patchSetId": 3
      },
      "lineNbr": 214,
      "author": {
        "id": 28676
      },
      "writtenOn": "2024-04-24T14:07:34Z",
      "side": 1,
      "message": "I think we need monitor) case for \"audit_enabled\" and \"audit_disabled\" actions. In monitor, we could do a little more checking other than the symlink checked by status, such as check output of \"swanctl --list-conn\" to ensure the floating IPs are in or not in the local_ts and remote_ts of system-nodes-local connection.\n\nsystem-nodes-local: IKEv1/2, no reauthentication, rekeying every 14400s\n  local:  %any\n  remote: %any\n  local unspecified authentication:\n  remote unspecified authentication:\n  node-bypass: PASS, no rekeying\n    local:  fdff:719a:bf60:2240::3/128 fdff:719a:bf60:2240::2/128\n    remote: fdff:719a:bf60:2240::3/128 fdff:719a:bf60:2240::2/128",
      "range": {
        "startLine": 214,
        "startChar": 0,
        "endLine": 214,
        "endChar": 2
      },
      "revId": "6b1fb029382983961207f64f778e5460debf9d8a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "5b76cbb7_c08e84ab",
        "filename": "sysinv/ipsec-auth/files/ipsec-config",
        "patchSetId": 3
      },
      "lineNbr": 214,
      "author": {
        "id": 35603
      },
      "writtenOn": "2024-04-24T16:03:38Z",
      "side": 1,
      "message": "Acknowledged. This will be addressed in the next Patchset.",
      "parentUuid": "8adceae0_38a4d845",
      "range": {
        "startLine": 214,
        "startChar": 0,
        "endLine": 214,
        "endChar": 2
      },
      "revId": "6b1fb029382983961207f64f778e5460debf9d8a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "359b86c5_abd120ad",
        "filename": "sysinv/ipsec-auth/files/ipsec-config",
        "patchSetId": 3
      },
      "lineNbr": 214,
      "author": {
        "id": 35603
      },
      "writtenOn": "2024-04-25T21:55:52Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "5b76cbb7_c08e84ab",
      "range": {
        "startLine": 214,
        "startChar": 0,
        "endLine": 214,
        "endChar": 2
      },
      "revId": "6b1fb029382983961207f64f778e5460debf9d8a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}