Update patch set 2
Patch Set 2: (4 comments) Patch-set: 2
This commit is contained in:
parent
84c1650004
commit
607012c833
|
@ -16,6 +16,98 @@
|
|||
"message": "Create tests, please.",
|
||||
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "4cd15a9e_a1549be2",
|
||||
"filename": "distributedcloud-client/dcmanagerclient/api/v1/phased_subcloud_deploy_manager.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 87,
|
||||
"author": {
|
||||
"id": 36476
|
||||
},
|
||||
"writtenOn": "2024-04-17T14:16:11Z",
|
||||
"side": 1,
|
||||
"message": "nit: since this call structure is repeated in each method, why don\u0027t we improve the code in _deploy_operation by moving the data and files retrieval there if it isn\u0027t specified?",
|
||||
"range": {
|
||||
"startLine": 83,
|
||||
"startChar": 0,
|
||||
"endLine": 87,
|
||||
"endChar": 71
|
||||
},
|
||||
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "cf951d93_7f2652f5",
|
||||
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 11,
|
||||
"author": {
|
||||
"id": 36476
|
||||
},
|
||||
"writtenOn": "2024-04-17T14:16:11Z",
|
||||
"side": 1,
|
||||
"message": "nit: this is not directly related to your changes, so it\u0027s okay if we do it later.\nInstead of importing the whole file, we should import only DCManagerShowOne",
|
||||
"range": {
|
||||
"startLine": 11,
|
||||
"startChar": 40,
|
||||
"endLine": 11,
|
||||
"endChar": 44
|
||||
},
|
||||
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "f0db13b6_fee28bf1",
|
||||
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 565,
|
||||
"author": {
|
||||
"id": 36476
|
||||
},
|
||||
"writtenOn": "2024-04-17T14:16:11Z",
|
||||
"side": 1,
|
||||
"message": "YAML file containing **the** parameters required for the **subcloud** enrollment.",
|
||||
"range": {
|
||||
"startLine": 564,
|
||||
"startChar": 18,
|
||||
"endLine": 565,
|
||||
"endChar": 29
|
||||
},
|
||||
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "b070393f_7372e70f",
|
||||
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 604,
|
||||
"author": {
|
||||
"id": 36476
|
||||
},
|
||||
"writtenOn": "2024-04-17T14:16:11Z",
|
||||
"side": 1,
|
||||
"message": "This code is duplicated in this file. I suggest creating a common method to do this operation, if possible.",
|
||||
"range": {
|
||||
"startLine": 597,
|
||||
"startChar": 0,
|
||||
"endLine": 604,
|
||||
"endChar": 82
|
||||
},
|
||||
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue