starlingx
/
distcloud-client
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(7 comments)

Patch-set: 4
CC: Gerrit User 35315 <35315@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 34605 \u003c34605@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35315\u003e replied on the change"}
This commit is contained in:
Gerrit User 35315 2024-02-27 16:01:24 +00:00 committed by Gerrit Code Review
parent a25c8306d7
commit dbe971da3b
1 changed files with 159 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

159
a948bb7859f5e74a958b3a3abc70499d32970da7 Normal file
View File

@ -0,0 +1,159 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "51ab09d4_72434da7",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 40,
"author": {
"id": 35315
},
"writtenOn": "2024-02-27T16:01:24Z",
"side": 1,
"message": "Need to add the dependency for the distcloud commit:\nhttps://review.opendev.org/c/starlingx/distcloud/+/909277",
"revId": "a948bb7859f5e74a958b3a3abc70499d32970da7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4dc1fc9e_2b5ed642",
"filename": "distributedcloud-client/dcmanagerclient/api/v1/subcloud_peer_group_manager.py",
"patchSetId": 4
},
"lineNbr": 1,
"author": {
"id": 35315
},
"writtenOn": "2024-02-27T16:01:24Z",
"side": 1,
"message": "2023-2024",
"range": {
"startLine": 1,
"startChar": 16,
"endLine": 1,
"endChar": 26
},
"revId": "a948bb7859f5e74a958b3a3abc70499d32970da7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "90a640f2_e3ae823c",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/subcloud_peer_group_manager.py",
"patchSetId": 4
},
"lineNbr": 1,
"author": {
"id": 35315
},
"writtenOn": "2024-02-27T16:01:24Z",
"side": 1,
"message": "2023-2024",
"range": {
"startLine": 1,
"startChar": 16,
"endLine": 1,
"endChar": 26
},
"revId": "a948bb7859f5e74a958b3a3abc70499d32970da7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4734425c_8cf673c8",
"filename": "distributedcloud-client/dcmanagerclient/tests/v1/test_subcloud_peer_group_manager.py",
"patchSetId": 4
},
"lineNbr": 1,
"author": {
"id": 35315
},
"writtenOn": "2024-02-27T16:01:24Z",
"side": 1,
"message": "2023-2024",
"range": {
"startLine": 1,
"startChar": 16,
"endLine": 1,
"endChar": 21
},
"revId": "a948bb7859f5e74a958b3a3abc70499d32970da7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f1270c66_597d12f4",
"filename": "distributedcloud-client/dcmanagerclient/tests/v1/test_subcloud_peer_group_manager.py",
"patchSetId": 4
},
"lineNbr": 38,
"author": {
"id": 35315
},
"writtenOn": "2024-02-27T16:01:24Z",
"side": 1,
"message": "Write \"info_message\u003dNone\" to be explicit.",
"range": {
"startLine": 38,
"startChar": 4,
"endLine": 38,
"endChar": 8
},
"revId": "a948bb7859f5e74a958b3a3abc70499d32970da7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a55a65d3_5e37d3c7",
"filename": "distributedcloud-client/dcmanagerclient/tests/v1/test_system_peer_manager.py",
"patchSetId": 4
},
"lineNbr": 2,
"author": {
"id": 35315
},
"writtenOn": "2024-02-27T16:01:24Z",
"side": 1,
"message": "2023-2024",
"range": {
"startLine": 2,
"startChar": 16,
"endLine": 2,
"endChar": 21
},
"revId": "a948bb7859f5e74a958b3a3abc70499d32970da7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "008b1058_3bb225fd",
"filename": "distributedcloud-client/dcmanagerclient/tests/v1/test_system_peer_manager.py",
"patchSetId": 4
},
"lineNbr": 98,
"author": {
"id": 35315
},
"writtenOn": "2024-02-27T16:01:24Z",
"side": 1,
"message": "Write \"info_message\u003dNone\" to be explicit.",
"range": {
"startLine": 98,
"startChar": 4,
"endLine": 98,
"endChar": 8
},
"revId": "a948bb7859f5e74a958b3a3abc70499d32970da7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}