183 lines
5.7 KiB
Plaintext
183 lines
5.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "5fa25aa9_e71058e1",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 14675
|
|
},
|
|
"writtenOn": "2024-04-17T13:54:55Z",
|
|
"side": 1,
|
|
"message": "Create tests, please.",
|
|
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "a6a1040e_594e1d87",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-17T14:16:43Z",
|
|
"side": 1,
|
|
"message": "Hugo, did you mean to create this as resolved? I\u0027ve removed it just in case.",
|
|
"parentUuid": "5fa25aa9_e71058e1",
|
|
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "ae0b2d03_6aa6532a",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 31954
|
|
},
|
|
"writtenOn": "2024-04-22T14:46:19Z",
|
|
"side": 1,
|
|
"message": "I would expect the enroll in phase operation also need the",
|
|
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4cd15a9e_a1549be2",
|
|
"filename": "distributedcloud-client/dcmanagerclient/api/v1/phased_subcloud_deploy_manager.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 87,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-17T14:16:11Z",
|
|
"side": 1,
|
|
"message": "nit: since this call structure is repeated in each method, why don\u0027t we improve the code in _deploy_operation by moving the data and files retrieval there if it isn\u0027t specified?",
|
|
"range": {
|
|
"startLine": 83,
|
|
"startChar": 0,
|
|
"endLine": 87,
|
|
"endChar": 71
|
|
},
|
|
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "cf951d93_7f2652f5",
|
|
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 11,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-17T14:16:11Z",
|
|
"side": 1,
|
|
"message": "nit: this is not directly related to your changes, so it\u0027s okay if we do it later.\nInstead of importing the whole file, we should import only DCManagerShowOne",
|
|
"range": {
|
|
"startLine": 11,
|
|
"startChar": 40,
|
|
"endLine": 11,
|
|
"endChar": 44
|
|
},
|
|
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "036cd9dd_286611f9",
|
|
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 561,
|
|
"author": {
|
|
"id": 31954
|
|
},
|
|
"writtenOn": "2024-04-22T14:37:39Z",
|
|
"side": 1,
|
|
"message": "Request install values and deploy values as well",
|
|
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "e3664711_23cbd33f",
|
|
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 561,
|
|
"author": {
|
|
"id": 31954
|
|
},
|
|
"writtenOn": "2024-04-22T14:46:19Z",
|
|
"side": 1,
|
|
"message": "Sorry for my mistake, the deploy config should not be necessary, but the install values, BMC password should be expected to have for the factory install the subclouds, I would @kyle and @salman to comment on this topic",
|
|
"parentUuid": "036cd9dd_286611f9",
|
|
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f0db13b6_fee28bf1",
|
|
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 565,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-17T14:16:11Z",
|
|
"side": 1,
|
|
"message": "YAML file containing **the** parameters required for the **subcloud** enrollment.",
|
|
"range": {
|
|
"startLine": 564,
|
|
"startChar": 18,
|
|
"endLine": 565,
|
|
"endChar": 29
|
|
},
|
|
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b070393f_7372e70f",
|
|
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 604,
|
|
"author": {
|
|
"id": 36476
|
|
},
|
|
"writtenOn": "2024-04-17T14:16:11Z",
|
|
"side": 1,
|
|
"message": "This code is duplicated in this file. I suggest creating a common method to do this operation, if possible.",
|
|
"range": {
|
|
"startLine": 597,
|
|
"startChar": 0,
|
|
"endLine": 604,
|
|
"endChar": 82
|
|
},
|
|
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |