starlingx
/
distcloud
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(17 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 36476 \u003c36476@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36476\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35230 \u003c35230@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36476\u003e replied on the change"}
This commit is contained in:
Gerrit User 36476 2024-04-25 18:46:36 +00:00 committed by Gerrit Code Review
parent 1e48ca3eb7
commit 040cf99829
1 changed files with 390 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

390
5803eb1b011549e39f96ac46dd5290ad670e2459
View File

@ -23,6 +23,30 @@
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "27f544ca_6e0b99ef",
"filename": "distributedcloud/dccommon/tests/unit/test_utils.py",
"patchSetId": 3
},
"lineNbr": 2,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "c77cefb2_d9a2eb70",
"range": {
"startLine": 2,
"startChar": 21,
"endLine": 2,
"endChar": 25
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -46,6 +70,30 @@
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d02bfe68_8fe91ce7",
"filename": "distributedcloud/dcmanager/tests/base.py",
"patchSetId": 3
},
"lineNbr": 205,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "9ce69f1f_0586c984",
"range": {
"startLine": 205,
"startChar": 8,
"endLine": 205,
"endChar": 55
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -69,6 +117,30 @@
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "59dde663_75cc0f6e",
"filename": "distributedcloud/dcmanager/tests/base.py",
"patchSetId": 3
},
"lineNbr": 217,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "7bdd7392_c382ec40",
"range": {
"startLine": 217,
"startChar": 8,
"endLine": 217,
"endChar": 55
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -109,6 +181,30 @@
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ea7188b3_c584cedc",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 333,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "It actually isn\u0027t redundant because the get request has two different behaviors: if there isn\u0027t a subcloud_ref, a list of subclouds is returned. Otherwise, if an id or name is sent, a subcloud\u0027s details is returned.\nI\u0027ve added a comment to specify that.",
"parentUuid": "45b09ab6_bad6e965",
"range": {
"startLine": 326,
"startChar": 0,
"endLine": 333,
"endChar": 63
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -132,6 +228,30 @@
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1759f6f3_fd6d5710",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 752,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "b0e9655c_f8da8627",
"range": {
"startLine": 752,
"startChar": 8,
"endLine": 752,
"endChar": 73
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -155,6 +275,30 @@
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "33d20663_48d9fe13",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 804,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "ee871fb5_9d85cfc2",
"range": {
"startLine": 804,
"startChar": 14,
"endLine": 804,
"endChar": 22
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -178,6 +322,30 @@
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c5bad857_6796f632",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 913,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "In those cases, they are necessary. If I remove those, from this test case and the one you commented below, they start to fail.",
"parentUuid": "3f61fdd8_d8c74af6",
"range": {
"startLine": 913,
"startChar": 8,
"endLine": 913,
"endChar": 49
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -201,6 +369,30 @@
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ac064db2_3320fc39",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 963,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Same comment as stated above.",
"parentUuid": "e816415e_037a0e45",
"range": {
"startLine": 960,
"startChar": 0,
"endLine": 963,
"endChar": 53
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -224,6 +416,30 @@
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "cec68360_7eff9a78",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1093,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Yes, if a None is sent in the network address a TypeError occurs. I believe we should create a bug for that.",
"parentUuid": "11de81e1_4256ae31",
"range": {
"startLine": 1093,
"startChar": 0,
"endLine": 1093,
"endChar": 54
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -247,6 +463,30 @@
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "6a76361e_0a5fd97d",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1157,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "9a4bef86_2986613e",
"range": {
"startLine": 1157,
"startChar": 8,
"endLine": 1157,
"endChar": 75
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -270,6 +510,30 @@
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d053d34a_ea5b60e9",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1159,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "01cd39c7_86810420",
"range": {
"startLine": 1159,
"startChar": 49,
"endLine": 1159,
"endChar": 57
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -293,6 +557,30 @@
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "847eb3ed_e271a02e",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1371,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "f6e9ee0d_0ebdd5f1",
"range": {
"startLine": 1371,
"startChar": 70,
"endLine": 1371,
"endChar": 71
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -310,6 +598,24 @@
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b635b35c_8b6276a1",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1427,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "179ceb3f_50021eaf",
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -333,6 +639,30 @@
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e163e13b_981b3483",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1764,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "5a6a34f8_26698b38",
"range": {
"startLine": 1763,
"startChar": 12,
"endLine": 1764,
"endChar": 70
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -350,6 +680,24 @@
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e9eb547a_748fe39c",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1805,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "e53f252f_6a97aa67",
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -367,6 +715,24 @@
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "bed6c41d_dda128bd",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 1848,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "1d515880_d3ed4812",
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -390,6 +756,30 @@
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "695d9c2e_6424d618",
"filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
"patchSetId": 3
},
"lineNbr": 2243,
"author": {
"id": 36476
},
"writtenOn": "2024-04-25T18:46:36Z",
"side": 1,
"message": "Done",
"parentUuid": "d459f949_a272ccb5",
"range": {
"startLine": 2243,
"startChar": 19,
"endLine": 2243,
"endChar": 27
},
"revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {