Update patch set 2

Patch Set 2:

(1 comment)

Patch-set: 2
This commit is contained in:
Gerrit User 8768 2018-11-09 20:52:18 +00:00 committed by Gerrit Code Review
parent ee736f5087
commit 2ec0950dc0
1 changed files with 27 additions and 0 deletions

View File

@ -0,0 +1,27 @@
{
"comments": [
{
"key": {
"uuid": "3f79a3b5_59a8831f",
"filename": "dcorch/engine/sync_services/network.py",
"patchSetId": 2
},
"lineNbr": 422,
"author": {
"id": 8768
},
"writtenOn": "2018-11-09T20:52:18Z",
"side": 1,
"message": "Tenant names are not guaranteed to be unique, only the name/domain tuple is.\n\nIf we can\u0027t change the domain then we\u0027re covered, but we should probably note that in a comment here. Alternately we could track the mapping between the different tenant IDs in the different subclouds.\n\nLastly, it\u0027s confusing to use tenant and project interchangeably, I think it\u0027d be better to pick one (probably project) and stick with it.",
"range": {
"startLine": 421,
"startChar": 10,
"endLine": 422,
"endChar": 26
},
"revId": "7c1c082be0e9c9bacfd251fe3fa1de33a0d2864f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}