starlingx
/
distcloud
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(2 comments)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 36476 \u003c36476@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36476\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 14675 \u003c14675@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36476\u003e replied on the change"}
This commit is contained in:
Gerrit User 36476 2024-04-23 12:39:32 +00:00 committed by Gerrit Code Review
parent a395aac931
commit 40550ec2bc
1 changed files with 44 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
f5113111311fc45c64d4bd38b55d818fe3e033f3 Normal file
View File

@ -0,0 +1,44 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "c6a1806d_b9854206",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 7,
"author": {
"id": 36476
},
"writtenOn": "2024-04-23T12:39:32Z",
"side": 1,
"message": "It\u0027s important to state what improvement was done in the main message. For example: Improve subcloud_get_all_with_status query efficiency",
"range": {
"startLine": 7,
"startChar": 0,
"endLine": 7,
"endChar": 43
},
"revId": "f5113111311fc45c64d4bd38b55d818fe3e033f3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "91c4a143_48ced2ad",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 36476
},
"writtenOn": "2024-04-23T12:39:32Z",
"side": 1,
"message": "I do believe that the coverage didn\u0027t lower, but can you also add a test to make sure it\u0027s okay?",
"revId": "f5113111311fc45c64d4bd38b55d818fe3e033f3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}