starlingx
/
distcloud
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(3 comments)

Patch-set: 3
Label: Workflow=0, 2a81ce0287000605279fa0779882b685e17336b9
Attention: {"person_ident":"Gerrit User 35230 \u003c35230@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35230\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 31954 \u003c31954@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35230\u003e replied on the change"}
This commit is contained in:
Gerrit User 35230 2024-05-06 20:28:39 +00:00 committed by Gerrit Code Review
parent 1604710f55
commit 51b4dc39e9
1 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
63b72d9ea542d10ceebf4f09441dd9b59ae29755
View File

@ -17,6 +17,24 @@
"revId": "63b72d9ea542d10ceebf4f09441dd9b59ae29755",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c83d28d0_831b2798",
"filename": "/COMMIT_MSG",
"patchSetId": 3
},
"lineNbr": 12,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:28:39Z",
"side": 1,
"message": "We did not remove the endpoint creation during the subcloud add yet. During the tests the existing endpoints were deleted manually from the keystone database. When testing the test case #3 I manually deleted the new endpoints from keystone DB after it was created, before new audit calls were made.\n\nThe plan is to remove the endpoint from Keystone DB after the services start using the new OpenStackDriver. Before removing them we\u0027ll modify the subcloud delete and network reconfiguration to send a notification request to refresh the endpoint cache, similar to what we already do during the network reconfiguration call.",
"parentUuid": "d6cd1862_77a9ea2b",
"revId": "63b72d9ea542d10ceebf4f09441dd9b59ae29755",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -34,6 +52,24 @@
"revId": "63b72d9ea542d10ceebf4f09441dd9b59ae29755",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "64cde2cd_d2ab1d96",
"filename": "distributedcloud/dccommon/endpoint_cache.py",
"patchSetId": 3
},
"lineNbr": 313,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:28:39Z",
"side": 1,
"message": "Just a matter of preference. I find it easier to reuse the method in other classes or context without requiring importing the whole class, it\u0027s also makes it explicit that these functions are not modifying or consuming anything from the class.\n\nI was going to add the unit tests during the DC service integration commits, but it makes sense to add unit tests for these simple functions as they do not depend on anything else. I\u0027ll add them in the next patchset 👍",
"parentUuid": "f01f1c1d_47f95571",
"revId": "63b72d9ea542d10ceebf4f09441dd9b59ae29755",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -50,6 +86,24 @@
"message": "Can we combine the none client and the token expiry case together as they are both doing the creation?",
"revId": "63b72d9ea542d10ceebf4f09441dd9b59ae29755",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8067351c_e1e38c44",
"filename": "distributedcloud/dccommon/endpoint_cache.py",
"patchSetId": 3
},
"lineNbr": 662,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:28:39Z",
"side": 1,
"message": "Yes. Do you think we should still keep the different log messages for each case?",
"parentUuid": "905f5b3c_2086214a",
"revId": "63b72d9ea542d10ceebf4f09441dd9b59ae29755",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}