From 649caf20d645c849c2bcb83b6958864c4df356de Mon Sep 17 00:00:00 2001
From: Gerrit User 35230 <35230@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Thu, 25 Apr 2024 20:06:54 +0000
Subject: [PATCH] Update patch set 5

Patch Set 5: Code-Review+2

(1 comment)

Patch-set: 5
Reviewer: Gerrit User 31954 <31954@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Reviewer: Gerrit User 35230 <35230@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 524a6a3e0506cb24b6933c1745a06357f302f842
Attention: {"person_ident":"Gerrit User 36476 \u003c36476@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35230\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35230 \u003c35230@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35230\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 31954 \u003c31954@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35230\u003e replied on the change"}
---
 5803eb1b011549e39f96ac46dd5290ad670e2459 | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/5803eb1b011549e39f96ac46dd5290ad670e2459 b/5803eb1b011549e39f96ac46dd5290ad670e2459
index d11971328..5d0a49187 100644
--- a/5803eb1b011549e39f96ac46dd5290ad670e2459
+++ b/5803eb1b011549e39f96ac46dd5290ad670e2459
@@ -346,6 +346,30 @@
       "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "96c35f46_641e95af",
+        "filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 913,
+      "author": {
+        "id": 35230
+      },
+      "writtenOn": "2024-04-25T20:06:54Z",
+      "side": 1,
+      "message": "Ack. Seems these are class attributes, so they persist across tests:\nhttps://opendev.org/starlingx/distcloud/src/branch/master/distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py#L211\n\nWe should improve this in the future.",
+      "parentUuid": "c5bad857_6796f632",
+      "range": {
+        "startLine": 913,
+        "startChar": 8,
+        "endLine": 913,
+        "endChar": 49
+      },
+      "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {