Update patch set 9
Patch Set 9:
(6 comments)
Patch-set: 9
Attention: {"person_ident":"Gerrit User 35809 \u003c35809@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35809\u003e replied on the change"}
This commit is contained in:
Gerrit User 35809
Gerrit Code Review
parent
a3a4492cd8
commit
6854d87325
|
|
@ -40,6 +40,30 @@
|
|||
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "370ecbfb_56ead8e9",
|
||||
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_system_peer_manager.py",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 68,
|
||||
"author": {
|
||||
"id": 35809
|
||||
},
|
||||
"writtenOn": "2024-04-29T05:43:07Z",
|
||||
"side": 1,
|
||||
"message": "Acknowledged",
|
||||
"parentUuid": "ae5e255b_c0ec41ec",
|
||||
"range": {
|
||||
"startLine": 64,
|
||||
"startChar": 0,
|
||||
"endLine": 68,
|
||||
"endChar": 64
|
||||
},
|
||||
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -63,6 +87,30 @@
|
|||
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "abcad0dc_eb65bf4e",
|
||||
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_system_peer_manager.py",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 138,
|
||||
"author": {
|
||||
"id": 35809
|
||||
},
|
||||
"writtenOn": "2024-04-29T05:43:07Z",
|
||||
"side": 1,
|
||||
"message": "Acknowledged",
|
||||
"parentUuid": "9b310c05_26ece59c",
|
||||
"range": {
|
||||
"startLine": 84,
|
||||
"startChar": 1,
|
||||
"endLine": 138,
|
||||
"endChar": 8
|
||||
},
|
||||
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -86,6 +134,30 @@
|
|||
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "fe46093c_8b3752bf",
|
||||
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_system_peer_manager.py",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 145,
|
||||
"author": {
|
||||
"id": 35809
|
||||
},
|
||||
"writtenOn": "2024-04-29T05:43:07Z",
|
||||
"side": 1,
|
||||
"message": "Acknowledged",
|
||||
"parentUuid": "73e468c5_5e4df037",
|
||||
"range": {
|
||||
"startLine": 145,
|
||||
"startChar": 8,
|
||||
"endLine": 145,
|
||||
"endChar": 50
|
||||
},
|
||||
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -103,6 +175,24 @@
|
|||
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "b59bf7e1_0206da46",
|
||||
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_system_peer_manager.py",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 287,
|
||||
"author": {
|
||||
"id": 35809
|
||||
},
|
||||
"writtenOn": "2024-04-29T05:43:07Z",
|
||||
"side": 1,
|
||||
"message": "yes, we are mocking utils get_local_system \n\nadded _mock_get_local_system in base.py since we are using it in test_subcloud_manager.py also",
|
||||
"parentUuid": "c479cdba_97aab1ba",
|
||||
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -126,6 +216,30 @@
|
|||
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "5556f2b2_4c20934c",
|
||||
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_system_peer_manager.py",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 289,
|
||||
"author": {
|
||||
"id": 35809
|
||||
},
|
||||
"writtenOn": "2024-04-29T05:43:07Z",
|
||||
"side": 1,
|
||||
"message": "Acknowledged",
|
||||
"parentUuid": "ba611f90_b2bf2773",
|
||||
"range": {
|
||||
"startLine": 288,
|
||||
"startChar": 0,
|
||||
"endLine": 289,
|
||||
"endChar": 62
|
||||
},
|
||||
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -148,6 +262,30 @@
|
|||
},
|
||||
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "7d1b8972_6660ebcb",
|
||||
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_system_peer_manager.py",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 339,
|
||||
"author": {
|
||||
"id": 35809
|
||||
},
|
||||
"writtenOn": "2024-04-29T05:43:07Z",
|
||||
"side": 1,
|
||||
"message": "added common mocks under base.py",
|
||||
"parentUuid": "a54856fb_ef38d3e8",
|
||||
"range": {
|
||||
"startLine": 329,
|
||||
"startChar": 8,
|
||||
"endLine": 339,
|
||||
"endChar": 56
|
||||
},
|
||||
"revId": "8284580c431615b7c19c6ebf956f6b5ff66a7a64",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue