starlingx
/
distcloud
Code Issues Proposed changes

Update patch set 7 

Patch Set 7:

(7 comments)

Patch-set: 7
This commit is contained in:
Gerrit User 14675 2024-04-23 13:45:29 +00:00 committed by Gerrit Code Review
parent 31456a585c
commit 7b12fa0557
1 changed files with 119 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

119
8d30f944d6eff7be5c3512912a0c1978b253ec1e
View File

@ -16,6 +16,125 @@
"message": "Please, resolve the comments after being addressed.",
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e2c7b3f1_7b37b4d8",
"filename": "distributedcloud/dcmanager/api/controllers/v1/phased_subcloud_deploy.py",
"patchSetId": 7
},
"lineNbr": 524,
"author": {
"id": 14675
},
"writtenOn": "2024-04-23T13:45:29Z",
"side": 1,
"message": "msg \u003d f\u0027Subcloud deploy status must be either: {valid_states_str}\u0027\npecan.abort(400, _(msg))",
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a5e84b10_b473b67a",
"filename": "distributedcloud/dcmanager/api/controllers/v1/phased_subcloud_deploy.py",
"patchSetId": 7
},
"lineNbr": 541,
"author": {
"id": 14675
},
"writtenOn": "2024-04-23T13:45:29Z",
"side": 1,
"message": "nit: don\u0027t need to use `f` in the first line of the msg.",
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "81afb33b_2d5c4d2d",
"filename": "distributedcloud/dcmanager/api/controllers/v1/phased_subcloud_deploy.py",
"patchSetId": 7
},
"lineNbr": 543,
"author": {
"id": 14675
},
"writtenOn": "2024-04-23T13:45:29Z",
"side": 1,
"message": "_(msg)",
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "aab5cd5a_8dd1659a",
"filename": "distributedcloud/dcmanager/api/controllers/v1/phased_subcloud_deploy.py",
"patchSetId": 7
},
"lineNbr": 550,
"author": {
"id": 14675
},
"writtenOn": "2024-04-23T13:45:29Z",
"side": 1,
"message": "If additional commits are required to complete this development, please create stub tests for now and implement them later.",
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d90c9f73_5c24b15c",
"filename": "distributedcloud/dcmanager/api/controllers/v1/phased_subcloud_deploy.py",
"patchSetId": 7
},
"lineNbr": 602,
"author": {
"id": 14675
},
"writtenOn": "2024-04-23T13:45:29Z",
"side": 1,
"message": "remove TODO",
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2319367d_adea87d3",
"filename": "distributedcloud/dcmanager/common/phased_subcloud_deploy.py",
"patchSetId": 7
},
"lineNbr": 167,
"author": {
"id": 14675
},
"writtenOn": "2024-04-23T13:45:29Z",
"side": 1,
"message": "this line is not necessary.",
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "63ab93c1_05b9ae06",
"filename": "distributedcloud/dcmanager/manager/subcloud_manager.py",
"patchSetId": 7
},
"lineNbr": 1577,
"author": {
"id": 14675
},
"writtenOn": "2024-04-23T13:45:29Z",
"side": 1,
"message": "We can use: raise NotImplementedError",
"revId": "8d30f944d6eff7be5c3512912a0c1978b253ec1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}