starlingx
/
distcloud
Code Issues Proposed changes

Update patch set 12 

Patch Set 12:

(5 comments)

Patch-set: 12
Attention: {"person_ident":"Gerrit User 36476 \u003c36476@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35809\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35809 \u003c35809@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35809\u003e replied on the change"}
This commit is contained in:
Gerrit User 35809 2024-04-30 09:07:41 +00:00 committed by Gerrit Code Review
parent 8d1501ee88
commit a83f6d5939
1 changed files with 108 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

108
362bfbc4f4b1b8493fe1c7f27134b7514d408dc4
View File

@ -23,6 +23,30 @@
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e8147a94_09367eb4",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 375,
"author": {
"id": 35809
},
"writtenOn": "2024-04-30T09:07:41Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "3e9a6ced_91fe3cc7",
"range": {
"startLine": 375,
"startChar": 13,
"endLine": 375,
"endChar": 29
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -46,6 +70,30 @@
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "656c9776_99c68443",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 489,
"author": {
"id": 35809
},
"writtenOn": "2024-04-30T09:07:41Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "cf55d4c7_7c620c3c",
"range": {
"startLine": 489,
"startChar": 0,
"endLine": 489,
"endChar": 35
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -69,6 +117,30 @@
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a5cac4aa_b7db4ff8",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 582,
"author": {
"id": 35809
},
"writtenOn": "2024-04-30T09:07:41Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "c4cb6293_f3e60a33",
"range": {
"startLine": 582,
"startChar": 0,
"endLine": 582,
"endChar": 32
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -86,6 +158,24 @@
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5e6ccf9c_02f3d7d2",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 593,
"author": {
"id": 35809
},
"writtenOn": "2024-04-30T09:07:41Z",
"side": 1,
"message": "removed it, since UT works without json.dumps mocking.",
"parentUuid": "da84ac16_97a25b90",
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -102,6 +192,24 @@
"message": "Please, work on this class\u0027 code duplication",
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f0863457_e0b7b129",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 3850,
"author": {
"id": 35809
},
"writtenOn": "2024-04-30T09:07:41Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "3b7ab7c9_f4cdb08e",
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}