starlingx
/
distcloud
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(3 comments)

Patch-set: 6
This commit is contained in:
Gerrit User 35441 2024-04-23 13:07:35 +00:00 committed by Gerrit Code Review
parent e26bc0d6fb
commit ce693a582a
2 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
1a9ad010ac800e12f1c93c41940b6910ef1d2735
View File

@ -16,6 +16,24 @@
"message": "Why are you returning an empty string?",
"revId": "1a9ad010ac800e12f1c93c41940b6910ef1d2735",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "19c17025_bf53ffa1",
"filename": "distributedcloud/dcmanager/api/controllers/v1/phased_subcloud_deploy.py",
"patchSetId": 6
},
"lineNbr": 548,
"author": {
"id": 35441
},
"writtenOn": "2024-04-23T13:07:35Z",
"side": 1,
"message": "To be able to return the desired dictionary, further development is needed in ansible. This command is being implemented in phases, this is the first one.",
"parentUuid": "fc67c5a4_63531156",
"revId": "1a9ad010ac800e12f1c93c41940b6910ef1d2735",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

36
1e5d5970a816c38d78e4708937609a97642e13b8
View File

@ -276,6 +276,24 @@
"revId": "1e5d5970a816c38d78e4708937609a97642e13b8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "fe287053_80030dd2",
"filename": "distributedcloud/dcmanager/api/controllers/v1/phased_subcloud_deploy.py",
"patchSetId": 4
},
"lineNbr": 525,
"author": {
"id": 35441
},
"writtenOn": "2024-04-23T13:07:35Z",
"side": 1,
"message": "Thanks for the help, the code is uploaded with f-string now.",
"parentUuid": "ab7caf10_6ab082bc",
"revId": "1e5d5970a816c38d78e4708937609a97642e13b8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -346,6 +364,24 @@
"revId": "1e5d5970a816c38d78e4708937609a97642e13b8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a23a1f13_e127f77f",
"filename": "distributedcloud/dcmanager/api/controllers/v1/phased_subcloud_deploy.py",
"patchSetId": 4
},
"lineNbr": 541,
"author": {
"id": 35441
},
"writtenOn": "2024-04-23T13:07:35Z",
"side": 1,
"message": "Issue resolved.",
"parentUuid": "f8b4d56c_26084ecd",
"revId": "1e5d5970a816c38d78e4708937609a97642e13b8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {