Update patch set 9

Patch Set 9:

(4 comments)

Patch-set: 9

3c9a9314ca0abad7485c999e844770021d5f8732

@@ -0,0 +1,84 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "4e9079d5_eebffcca",
+        "filename": "distributedcloud/dcmanager/api/controllers/v1/phased_subcloud_deploy.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 551,
+      "author": {
+        "id": 36476
+      },
+      "writtenOn": "2024-04-26T14:24:41Z",
+      "side": 1,
+      "message": "This return is never reached because of the pecan.abort above. It can just be removed",
+      "revId": "3c9a9314ca0abad7485c999e844770021d5f8732",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "9d7619cb_a89e8a74",
+        "filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_phased_subcloud_deploy.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 1080,
+      "author": {
+        "id": 36476
+      },
+      "writtenOn": "2024-04-26T14:24:41Z",
+      "side": 1,
+      "message": "Remember to be consistent in the naming and documentation\n\nclass TestPhasedSubcloudDeployPatchEnroll(BaseTestPhasedSubcloudDeployPatch):\n    \"\"\"Test class for patch requests with enroll verb\"\"\"",
+      "revId": "3c9a9314ca0abad7485c999e844770021d5f8732",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "b1743d25_bb698bef",
+        "filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_phased_subcloud_deploy.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 1102,
+      "author": {
+        "id": 36476
+      },
+      "writtenOn": "2024-04-26T14:24:41Z",
+      "side": 1,
+      "message": "Remember to remove those lines if they are unused",
+      "range": {
+        "startLine": 1101,
+        "startChar": 0,
+        "endLine": 1102,
+        "endChar": 32
+      },
+      "revId": "3c9a9314ca0abad7485c999e844770021d5f8732",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "a6e49f96_fdb17316",
+        "filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_phased_subcloud_deploy.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 1106,
+      "author": {
+        "id": 36476
+      },
+      "writtenOn": "2024-04-26T14:24:41Z",
+      "side": 1,
+      "message": "There should be, at least, two or three more test cases since there are other two scenarios where an abort happens and there\u0027s one more in the if condition that might not be covered.\nRun tox -c distributedcloud/tox.ini -e cover and verify the coverage.",
+      "range": {
+        "startLine": 1081,
+        "startChar": 0,
+        "endLine": 1106,
+        "endChar": 9
+      },
+      "revId": "3c9a9314ca0abad7485c999e844770021d5f8732",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}