distcloud/18ea7209d7003c39ad446700df70c721bdd21915

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "ba1f41b3_815a2d14",
        "filename": "/COMMIT_MSG",
        "patchSetId": 7
      },
      "lineNbr": 9,
      "author": {
        "id": 36476
      },
      "writtenOn": "2024-04-23T13:08:43Z",
      "side": 1,
      "message": "Please, improve the description to be more detailed",
      "revId": "18ea7209d7003c39ad446700df70c721bdd21915",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "3367a07d_201008d5",
        "filename": "/COMMIT_MSG",
        "patchSetId": 7
      },
      "lineNbr": 17,
      "author": {
        "id": 36476
      },
      "writtenOn": "2024-04-23T13:08:43Z",
      "side": 1,
      "message": "Just FYI, we don\u0027t need to explicitly state a dependency when a commit is in the same relation chain as the one it depends on, but there\u0027s also no problem in adding this.",
      "revId": "18ea7209d7003c39ad446700df70c721bdd21915",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "60801e28_f2413a62",
        "filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
        "patchSetId": 7
      },
      "lineNbr": 77,
      "author": {
        "id": 36476
      },
      "writtenOn": "2024-04-23T13:08:43Z",
      "side": 1,
      "message": "Instead of hard-coding the value, use a variable that comes from init, just like you did for the other ones.",
      "range": {
        "startLine": 77,
        "startChar": 26,
        "endLine": 77,
        "endChar": 28
      },
      "revId": "18ea7209d7003c39ad446700df70c721bdd21915",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "6cc47e29_7dbcd22e",
        "filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
        "patchSetId": 7
      },
      "lineNbr": 630,
      "author": {
        "id": 36476
      },
      "writtenOn": "2024-04-23T13:08:43Z",
      "side": 1,
      "message": "These lines are duplicated in the tests above. Make sure they are in the setup function of their new class",
      "range": {
        "startLine": 620,
        "startChar": 0,
        "endLine": 630,
        "endChar": 40
      },
      "revId": "18ea7209d7003c39ad446700df70c721bdd21915",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "f89fcfd4_37fcf56e",
        "filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
        "patchSetId": 7
      },
      "lineNbr": 633,
      "author": {
        "id": 36476
      },
      "writtenOn": "2024-04-23T13:08:43Z",
      "side": 1,
      "message": "All of these tests are in the incorrect class. The base class can\u0027t contain test cases, otherwise it will execute them in all of the classes that inherit it.",
      "range": {
        "startLine": 538,
        "startChar": 2,
        "endLine": 633,
        "endChar": 0
      },
      "revId": "18ea7209d7003c39ad446700df70c721bdd21915",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "d54bb956_c22b45fa",
        "filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
        "patchSetId": 7
      },
      "lineNbr": 3928,
      "author": {
        "id": 36476
      },
      "writtenOn": "2024-04-23T13:08:43Z",
      "side": 1,
      "message": "This seems to be used in many test cases and in different classes. Try to move it to the base class",
      "revId": "18ea7209d7003c39ad446700df70c721bdd21915",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "6e8ff94f_05e23a38",
        "filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
        "patchSetId": 7
      },
      "lineNbr": 3988,
      "author": {
        "id": 36476
      },
      "writtenOn": "2024-04-23T13:08:43Z",
      "side": 1,
      "message": "Update these mock declarations to use the mocks you created",
      "range": {
        "startLine": 3985,
        "startChar": 0,
        "endLine": 3988,
        "endChar": 59
      },
      "revId": "18ea7209d7003c39ad446700df70c721bdd21915",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}