starlingx
/
docs
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(10 comments)

Patch-set: 1
Reviewer: Gerrit User 30539 <30539@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, e5c7fa8c70d075114ffe416371b33436ca64939e
Attention: {"person_ident":"Gerrit User 33342 \u003c33342@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_30539\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 30539 \u003c30539@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_30539\u003e replied on the change"}
This commit is contained in:
Gerrit User 30539 2024-05-06 16:52:18 +00:00 committed by Gerrit Code Review
parent 0128cd4f04
commit 013f7b7275
1 changed files with 228 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

228
ed54fa35abe7eec0f76b97aac58cbad188ad65ae Normal file
View File

@ -0,0 +1,228 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "eeb8cd8a_1f0cbb38",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 30539
},
"writtenOn": "2024-05-06T16:52:18Z",
"side": 1,
"message": "A few editorial things.",
"revId": "ed54fa35abe7eec0f76b97aac58cbad188ad65ae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a0fc8cc2_c69bffe5",
"filename": "doc/source/guest_integration/kubernetes/node-interface-metrics-exporter-application-d98b2707c7e9.rst",
"patchSetId": 1
},
"lineNbr": 27,
"author": {
"id": 30539
},
"writtenOn": "2024-05-06T16:52:18Z",
"side": 1,
"message": "add . (period)",
"range": {
"startLine": 27,
"startChar": 18,
"endLine": 27,
"endChar": 28
},
"revId": "ed54fa35abe7eec0f76b97aac58cbad188ad65ae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f577b0dc_471a9269",
"filename": "doc/source/guest_integration/kubernetes/node-interface-metrics-exporter-application-d98b2707c7e9.rst",
"patchSetId": 1
},
"lineNbr": 40,
"author": {
"id": 30539
},
"writtenOn": "2024-05-06T16:52:18Z",
"side": 1,
"message": "add . (period)",
"range": {
"startLine": 40,
"startChar": 29,
"endLine": 40,
"endChar": 32
},
"revId": "ed54fa35abe7eec0f76b97aac58cbad188ad65ae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "667ab406_84cbd9c8",
"filename": "doc/source/guest_integration/kubernetes/node-interface-metrics-exporter-application-d98b2707c7e9.rst",
"patchSetId": 1
},
"lineNbr": 80,
"author": {
"id": 30539
},
"writtenOn": "2024-05-06T16:52:18Z",
"side": 1,
"message": "The application",
"range": {
"startLine": 80,
"startChar": 4,
"endLine": 80,
"endChar": 16
},
"revId": "ed54fa35abe7eec0f76b97aac58cbad188ad65ae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1658a4c5_a22c4f48",
"filename": "doc/source/guest_integration/kubernetes/node-interface-metrics-exporter-application-d98b2707c7e9.rst",
"patchSetId": 1
},
"lineNbr": 123,
"author": {
"id": 30539
},
"writtenOn": "2024-05-06T16:52:18Z",
"side": 1,
"message": "The following",
"range": {
"startLine": 123,
"startChar": 4,
"endLine": 123,
"endChar": 14
},
"revId": "ed54fa35abe7eec0f76b97aac58cbad188ad65ae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d8d9adab_2c6666c8",
"filename": "doc/source/guest_integration/kubernetes/node-interface-metrics-exporter-application-d98b2707c7e9.rst",
"patchSetId": 1
},
"lineNbr": 124,
"author": {
"id": 30539
},
"writtenOn": "2024-05-06T16:52:18Z",
"side": 1,
"message": "be exported",
"range": {
"startLine": 124,
"startChar": 43,
"endLine": 124,
"endChar": 51
},
"revId": "ed54fa35abe7eec0f76b97aac58cbad188ad65ae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0a9f27fd_d0774dfc",
"filename": "doc/source/guest_integration/kubernetes/node-interface-metrics-exporter-application-d98b2707c7e9.rst",
"patchSetId": 1
},
"lineNbr": 138,
"author": {
"id": 30539
},
"writtenOn": "2024-05-06T16:52:18Z",
"side": 1,
"message": "Suggest using ``/metrics`` on the first list item to carry the context forward.",
"range": {
"startLine": 138,
"startChar": 8,
"endLine": 138,
"endChar": 10
},
"revId": "ed54fa35abe7eec0f76b97aac58cbad188ad65ae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "fc65deab_29d97fe1",
"filename": "doc/source/guest_integration/kubernetes/node-interface-metrics-exporter-application-d98b2707c7e9.rst",
"patchSetId": 1
},
"lineNbr": 311,
"author": {
"id": 30539
},
"writtenOn": "2024-05-06T16:52:18Z",
"side": 1,
"message": "As above, suggest carrying the full noun, ``/metrics/device/{device_name}``, forward on first usage in list",
"range": {
"startLine": 311,
"startChar": 55,
"endLine": 311,
"endChar": 57
},
"revId": "ed54fa35abe7eec0f76b97aac58cbad188ad65ae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7eef8e82_38c8b731",
"filename": "doc/source/guest_integration/kubernetes/node-interface-metrics-exporter-application-d98b2707c7e9.rst",
"patchSetId": 1
},
"lineNbr": 488,
"author": {
"id": 30539
},
"writtenOn": "2024-05-06T16:52:18Z",
"side": 1,
"message": "As above, ``/metrics/pci-addr/{pci_address}``",
"range": {
"startLine": 488,
"startChar": 74,
"endLine": 488,
"endChar": 76
},
"revId": "ed54fa35abe7eec0f76b97aac58cbad188ad65ae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5d1bb902_f6661ef5",
"filename": "doc/source/guest_integration/kubernetes/node-interface-metrics-exporter-application-d98b2707c7e9.rst",
"patchSetId": 1
},
"lineNbr": 489,
"author": {
"id": 30539
},
"writtenOn": "2024-05-06T16:52:18Z",
"side": 1,
"message": "Suggest \"It also provides\" to avoid the clause.",
"range": {
"startLine": 489,
"startChar": 56,
"endLine": 489,
"endChar": 65
},
"revId": "ed54fa35abe7eec0f76b97aac58cbad188ad65ae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}