starlingx
/
docs
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review+2

(1 comment)

This comment isn't enough to hold this review up but I would like to get a consensus at some point on style guidelines.  OpenStack has some or we can write our own.

Patch-set: 4
Label: Code-Review=+2
This commit is contained in:
Gerrit User 970 2018-10-23 20:47:06 +00:00 committed by Gerrit Code Review
parent 943a81ca1a
commit 4610e1abc2
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
ad56abc446163b34ce78473206894fdab5eaf1de Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "3f79a3b5_cb05f610",
"filename": "api-ref/source/index.rst",
"patchSetId": 4
},
"lineNbr": 5,
"author": {
"id": 970
},
"writtenOn": "2018-10-23T20:47:06Z",
"side": 1,
"message": "so consistent style question, either the lines match the width or they extend past, I really don\u0027t care, but shouldn\u0027t we pick one or the other?",
"revId": "ad56abc446163b34ce78473206894fdab5eaf1de",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}