starlingx
/
docs
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(5 comments)

Patch-set: 1
Reviewer: Gerrit User 8768 <8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, f293ce850c8c010d8ac7a16c0f57cba304c2bd54
Attention: {"person_ident":"Gerrit User 33342 \u003c33342@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8768\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 8768 \u003c8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_8768\u003e replied on the change"}
This commit is contained in:
Gerrit User 8768 2024-05-03 19:23:25 +00:00 committed by Gerrit Code Review
parent d8412bce84
commit fb0dd7b9cd
1 changed files with 119 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

119
557ef6d8f0dc24559b6e9e7c8bbeb4f188e9ca88 Normal file
View File

@ -0,0 +1,119 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "902fbd93_f3d9a91c",
"filename": "doc/source/node_management/kubernetes/hardware_acceleration_devices/marvell-octeon-nic-accelerator-support-0ca20e6fc2c9.rst",
"patchSetId": 1
},
"lineNbr": 7,
"author": {
"id": 8768
},
"writtenOn": "2024-05-03T19:23:25Z",
"side": 1,
"message": "There could be other accelerator cards based on this chip, so we should probably mention the DORA as just one example.",
"range": {
"startLine": 7,
"startChar": 0,
"endLine": 7,
"endChar": 74
},
"revId": "557ef6d8f0dc24559b6e9e7c8bbeb4f188e9ca88",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "edc0de9c_b610e0af",
"filename": "doc/source/node_management/kubernetes/hardware_acceleration_devices/marvell-octeon-nic-accelerator-support-0ca20e6fc2c9.rst",
"patchSetId": 1
},
"lineNbr": 7,
"author": {
"id": 8768
},
"writtenOn": "2024-05-03T19:23:25Z",
"side": 1,
"message": "use |DORA| here?",
"range": {
"startLine": 7,
"startChar": 36,
"endLine": 7,
"endChar": 61
},
"revId": "557ef6d8f0dc24559b6e9e7c8bbeb4f188e9ca88",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "87e4aff1_d3dceb83",
"filename": "doc/source/node_management/kubernetes/hardware_acceleration_devices/marvell-octeon-nic-accelerator-support-0ca20e6fc2c9.rst",
"patchSetId": 1
},
"lineNbr": 9,
"author": {
"id": 8768
},
"writtenOn": "2024-05-03T19:23:25Z",
"side": 1,
"message": "This is true for the DORA but not necessarily for all accelerators based on the Marvel chip.",
"range": {
"startLine": 8,
"startChar": 55,
"endLine": 9,
"endChar": 68
},
"revId": "557ef6d8f0dc24559b6e9e7c8bbeb4f188e9ca88",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b3382032_c2f26b31",
"filename": "doc/source/node_management/kubernetes/hardware_acceleration_devices/marvell-octeon-nic-accelerator-support-0ca20e6fc2c9.rst",
"patchSetId": 1
},
"lineNbr": 20,
"author": {
"id": 8768
},
"writtenOn": "2024-05-03T19:23:25Z",
"side": 1,
"message": "This list of steps is only applicable to the DORA, and is not necessarily true for other accelerators based on the same chip.",
"range": {
"startLine": 9,
"startChar": 70,
"endLine": 20,
"endChar": 42
},
"revId": "557ef6d8f0dc24559b6e9e7c8bbeb4f188e9ca88",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "963bb942_1f4dd70b",
"filename": "doc/source/node_management/kubernetes/hardware_acceleration_devices/marvell-octeon-nic-accelerator-support-0ca20e6fc2c9.rst",
"patchSetId": 1
},
"lineNbr": 24,
"author": {
"id": 8768
},
"writtenOn": "2024-05-03T19:23:25Z",
"side": 1,
"message": "may want to mention that this will cause problems due to the drivers not being loaded by default at boot time.",
"range": {
"startLine": 23,
"startChar": 13,
"endLine": 24,
"endChar": 13
},
"revId": "557ef6d8f0dc24559b6e9e7c8bbeb4f188e9ca88",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}