From 2f364daa08c64b8976edf7140d3ca85b556ba974 Mon Sep 17 00:00:00 2001 From: Sharath Kumar K Date: Mon, 20 Apr 2020 18:50:47 +0200 Subject: [PATCH] Tox and Zuul job for the python code scan in starlingx/fault Setting up the bandit tool for the scanning of HIGH severity issues in the python codes under Starlingx/fault folder. Expecting this merge will enable zuul job for CI/CD of bandit scan. Configuration files: 1. tox.ini for adding bandit environment and command. 2. test-requirements.txt for adding bandit version. 3. .zuul.yaml file for adding bandit job and configuring under check job to run code scan every time before code commit. Test: Run tox -e bandit command inside the fault folder to validate the bandit scan and result. Please note: Changes will be implemented in batches and this is Batch2 change. Story: 2007541 Task: 39490 Depends-On: https://review.opendev.org/#/c/721294/ Change-Id: I84449691281d9769e9219e6f9f1338c20f518f40 Signed-off-by: Sharath Kumar K --- .zuul.yaml | 1 + test-requirements.txt | 1 + tox.ini | 5 +++++ 3 files changed, 7 insertions(+) diff --git a/.zuul.yaml b/.zuul.yaml index 4bcb0ae8..917d7490 100644 --- a/.zuul.yaml +++ b/.zuul.yaml @@ -6,6 +6,7 @@ - stx-api-ref-jobs - stx-release-notes-jobs - stx-lint-specfile-jobs + - stx-bandit-jobs check: jobs: - openstack-tox-linters diff --git a/test-requirements.txt b/test-requirements.txt index 8f1b9382..f88cf028 100644 --- a/test-requirements.txt +++ b/test-requirements.txt @@ -4,3 +4,4 @@ mock PyYAML >= 3.1.0 yamllint >= 0.5.2 #spec_cleaner>=1.0.9 +bandit!=1.6.0,>=1.1.0,<2.0.0 diff --git a/tox.ini b/tox.ini index 17cf525c..5c8cf305 100644 --- a/tox.ini +++ b/tox.ini @@ -146,3 +146,8 @@ basepython = python3 whitelist_externals = cat commands = cat /etc/fm/fm.conf +[testenv:bandit] +basepython = python3 +description = Bandit code scan for *.py files under config folder +deps = -r{toxinidir}/test-requirements.txt +commands = bandit -r {toxinidir}/ -x '**/.tox/**',**/.eggs/** -lll