starlingx
/
fault
Code Issues Proposed changes

Update patch set 9 

Patch Set 9:

(2 comments)

Patch-set: 9
Attention: {"person_ident":"Gerrit User 28486 \u003c28486@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28486\u003e replied on the change"}
This commit is contained in:
Gerrit User 28486 2024-02-13 18:45:25 +00:00 committed by Gerrit Code Review
parent 54f888d301
commit 2f36f437e2
1 changed files with 50 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
ae0d2d9606895f8d4f3eb5594c137c3d4580fca1 Normal file
View File

@ -0,0 +1,50 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "6dfede42_eada13a3",
"filename": "/COMMIT_MSG",
"patchSetId": 9
},
"lineNbr": 15,
"author": {
"id": 28486
},
"writtenOn": "2024-02-13T18:45:25Z",
"side": 1,
"message": "The only logical test is to verify successful tox test and package build. Otherwise this commit would depend on https://review.opendev.org/c/starlingx/config/+/906952",
"range": {
"startLine": 13,
"startChar": 0,
"endLine": 15,
"endChar": 0
},
"revId": "ae0d2d9606895f8d4f3eb5594c137c3d4580fca1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f9dffbc4_bcbfb5f0",
"filename": "fm-doc/fm_doc/events.yaml",
"patchSetId": 9
},
"lineNbr": 3447,
"author": {
"id": 28486
},
"writtenOn": "2024-02-13T18:45:25Z",
"side": 1,
"message": "Don\u0027t forget to update the test plan of https://review.opendev.org/c/starlingx/config/+/906952. The author of that commit needs to verify that platform patching/upgrade will not proceed when the system has this alarm.",
"range": {
"startLine": 3447,
"startChar": 4,
"endLine": 3447,
"endChar": 40
},
"revId": "ae0d2d9606895f8d4f3eb5594c137c3d4580fca1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}