starlingx
/
fault
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 28464 \u003c28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_26026\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35298 \u003c35298@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_26026\u003e replied on the change"}
This commit is contained in:
Gerrit User 26026 2023-12-11 13:25:54 +00:00 committed by Gerrit Code Review
parent de0954b661
commit 36926d3bd8
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
77725b3121e06265360f5a1a690afa283c4abeff
View File

@ -22,6 +22,30 @@
},
"revId": "77725b3121e06265360f5a1a690afa283c4abeff",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "368240dd_9b3dd583",
"filename": "fm-doc/fm_doc/events.yaml",
"patchSetId": 2
},
"lineNbr": 802,
"author": {
"id": 26026
},
"writtenOn": "2023-12-11T13:25:54Z",
"side": 1,
"message": "In general, in the future ... I suspect host will NOT be able to do it\u0027s core function without being to create or unseal the LUKS filesystem.\n\ne.g. initially, on controllers, we are only storing the kube-apiserver\u0027s etcd encryption key in LUKS ... but without access to that, then kubernetes can NOT read it\u0027s configuration database (etcd)\n\nin future, all hosts will store critical security-sensitive information like keys, passwords, etc in the LUKS filesystem.\n\n\nUpgrade or patching should not be allowed if LUKS is failing ... that should be fixed first.\n\nSo \u0027Management_Affecting_Severity\u0027 should probably be true.",
"parentUuid": "2d1b53c4_e31f30ef",
"range": {
"startLine": 802,
"startChar": 4,
"endLine": 802,
"endChar": 33
},
"revId": "77725b3121e06265360f5a1a690afa283c4abeff",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}