starlingx
/
fault
Code Issues Proposed changes

Update patch set 6 

Patch Set 6: Code-Review-1

(3 comments)

Patch-set: 6
Reviewer: Gerrit User 8768 <8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 927753860004151c145476d3e124fc81a6f47193
Attention: {"person_ident":"Gerrit User 36436 \u003c36436@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8768\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 8768 \u003c8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_8768\u003e replied on the change"}
This commit is contained in:
Gerrit User 8768 2024-02-02 23:05:12 +00:00 committed by Gerrit Code Review
parent 710406dc1b
commit b77d4a21a7
1 changed files with 67 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

67
5ec2f1f37b2a3d5bdfb5d1f1783afbd6e08f16f5 Normal file
View File

@ -0,0 +1,67 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "8deb3141_07cf6fa7",
"filename": "/COMMIT_MSG",
"patchSetId": 6
},
"lineNbr": 11,
"author": {
"id": 8768
},
"writtenOn": "2024-02-02T23:05:12Z",
"side": 1,
"message": "this could be a bit more clear, and needs a Story/Task. Maybe take a look at the commit message for commit 65a8ff3d66bbd87 in this repo to see a good commit message.",
"revId": "5ec2f1f37b2a3d5bdfb5d1f1783afbd6e08f16f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1f49387d_5e953571",
"filename": "/COMMIT_MSG",
"patchSetId": 6
},
"lineNbr": 16,
"author": {
"id": 8768
},
"writtenOn": "2024-02-02T23:05:12Z",
"side": 1,
"message": "this commit doesn\u0027t really need any testing beyond compiling the package.",
"range": {
"startLine": 13,
"startChar": 0,
"endLine": 16,
"endChar": 33
},
"revId": "5ec2f1f37b2a3d5bdfb5d1f1783afbd6e08f16f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2b69177e_39668c23",
"filename": "fm-api/source/fm_api/constants.py",
"patchSetId": 6
},
"lineNbr": 313,
"author": {
"id": 8768
},
"writtenOn": "2024-02-02T23:05:12Z",
"side": 1,
"message": "shouldn\u0027t we add this under the other ALARM_GROUP_K8S alarm at line 116?",
"range": {
"startLine": 312,
"startChar": 0,
"endLine": 313,
"endChar": 56
},
"revId": "5ec2f1f37b2a3d5bdfb5d1f1783afbd6e08f16f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}