starlingx
/
gui
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(7 comments)

Patch-set: 2
This commit is contained in:
Gerrit User 35110 2023-11-03 09:50:58 +00:00 committed by Gerrit Code Review
parent 1fc587a7ce
commit 9aebda218b
2 changed files with 129 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

112
79a35bfeab953841ed2218f72d0605f0809aa982 Normal file
View File

@ -0,0 +1,112 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "a3c1a0ce_c13efaad",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/admin/software_management/forms.py",
"patchSetId": 1
},
"lineNbr": 9,
"author": {
"id": 35110
},
"writtenOn": "2023-11-03T09:50:58Z",
"side": 1,
"message": "\u003e pep8: H301: one import per line\n\nPlease fix.",
"parentUuid": "39fd4d10_444384f8",
"revId": "79a35bfeab953841ed2218f72d0605f0809aa982",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "89038132_09dacfa2",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/admin/software_management/forms.py",
"patchSetId": 1
},
"lineNbr": 20,
"author": {
"id": 35110
},
"writtenOn": "2023-11-03T09:50:58Z",
"side": 1,
"message": "\u003e pep8: E302 expected 2 blank lines, found 1\n\nPlease fix.",
"parentUuid": "de32303f_4e02e0a2",
"revId": "79a35bfeab953841ed2218f72d0605f0809aa982",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "efec1dbf_b29e72b5",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/admin/software_management/forms.py",
"patchSetId": 1
},
"lineNbr": 23,
"author": {
"id": 35110
},
"writtenOn": "2023-11-03T09:50:58Z",
"side": 1,
"message": "\u003e pep8: E302 expected 2 blank lines, found 1\n\nPlease fix.",
"parentUuid": "997e7673_240a4a06",
"revId": "79a35bfeab953841ed2218f72d0605f0809aa982",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3d7d19ed_794cfa53",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/admin/software_management/forms.py",
"patchSetId": 1
},
"lineNbr": 36,
"author": {
"id": 35110
},
"writtenOn": "2023-11-03T09:50:58Z",
"side": 1,
"message": "\u003e pep8: E302 expected 2 blank lines, found 1\n\nPlease fix.",
"parentUuid": "5b8b8951_11ed3ac8",
"revId": "79a35bfeab953841ed2218f72d0605f0809aa982",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "71d07bf0_f81a394e",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/admin/software_management/forms.py",
"patchSetId": 1
},
"lineNbr": 39,
"author": {
"id": 35110
},
"writtenOn": "2023-11-03T09:50:58Z",
"side": 1,
"message": "\u003e pep8: E128 continuation line under-indented for visual indent\n\nPlease fix.",
"parentUuid": "fc1cf0b3_ec867947",
"revId": "79a35bfeab953841ed2218f72d0605f0809aa982",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "98c32ab3_a1c38921",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/admin/software_management/forms.py",
"patchSetId": 1
},
"lineNbr": 42,
"author": {
"id": 35110
},
"writtenOn": "2023-11-03T09:50:58Z",
"side": 1,
"message": "\u003e pep8: E128 continuation line under-indented for visual indent\n\nPlease fix.",
"parentUuid": "f30f65dc_dbafd140",
"revId": "79a35bfeab953841ed2218f72d0605f0809aa982",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

17
ddbd9fb09e420951670490f05b5c76a9f5c1685f
View File

@ -16,6 +16,23 @@
"message": "recheck",
"revId": "ddbd9fb09e420951670490f05b5c76a9f5c1685f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e449d651_ec779097",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 35110
},
"writtenOn": "2023-11-03T09:50:58Z",
"side": 1,
"message": "recheck",
"revId": "ddbd9fb09e420951670490f05b5c76a9f5c1685f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}