From 3eae5203fecdc81084c4fcdf5a253a162d7c203b Mon Sep 17 00:00:00 2001 From: Gerrit User 28464 <28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Mon, 1 Apr 2024 15:53:29 +0000 Subject: [PATCH] Update patch set 8 Patch Set 8: Code-Review+1 (4 comments) Patch-set: 8 Reviewer: Gerrit User 28464 <28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+1, 520c54d7c9e71315a750b7297addf06234f0ad03 Attention: {"person_ident":"Gerrit User 32933 \u003c32933@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28464\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 28464 \u003c28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28464\u003e replied on the change"} --- 10dfa8a9c436e39037ba37a7492a1ebd122c54a2 | 96 ++++++++++++++++++++++++ 1 file changed, 96 insertions(+) create mode 100644 10dfa8a9c436e39037ba37a7492a1ebd122c54a2 diff --git a/10dfa8a9c436e39037ba37a7492a1ebd122c54a2 b/10dfa8a9c436e39037ba37a7492a1ebd122c54a2 new file mode 100644 index 00000000..5eecc6fe --- /dev/null +++ b/10dfa8a9c436e39037ba37a7492a1ebd122c54a2 @@ -0,0 +1,96 @@ +{ + "comments": [ + { + "unresolved": true, + "key": { + "uuid": "ed3338b8_e8e3b2f2", + "filename": "/COMMIT_MSG", + "patchSetId": 8 + }, + "lineNbr": 18, + "author": { + "id": 28464 + }, + "writtenOn": "2024-04-01T15:53:29Z", + "side": 1, + "message": "nit: sys", + "range": { + "startLine": 18, + "startChar": 13, + "endLine": 18, + "endChar": 16 + }, + "revId": "10dfa8a9c436e39037ba37a7492a1ebd122c54a2", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "cb105fd4_37d1b778", + "filename": "/COMMIT_MSG", + "patchSetId": 8 + }, + "lineNbr": 24, + "author": { + "id": 28464 + }, + "writtenOn": "2024-04-01T15:53:29Z", + "side": 1, + "message": "nit: sys", + "range": { + "startLine": 24, + "startChar": 13, + "endLine": 24, + "endChar": 16 + }, + "revId": "10dfa8a9c436e39037ba37a7492a1ebd122c54a2", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "266abc46_4e5c1c1a", + "filename": "service-mgmt/sm-db/database/create_sm_db.sql", + "patchSetId": 8 + }, + "lineNbr": 40, + "author": { + "id": 28464 + }, + "writtenOn": "2024-04-01T15:53:29Z", + "side": 1, + "message": "nit: Suggest putting these in numbered order 1,5,2,10\n\nI know it does not keep the ipv6 services together and with ipv4, but the existing strict ordering would be maintained.", + "range": { + "startLine": 37, + "startChar": 0, + "endLine": 40, + "endChar": 103 + }, + "revId": "10dfa8a9c436e39037ba37a7492a1ebd122c54a2", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "147d8fa5_60bf977c", + "filename": "service-mgmt/sm-db/database/create_sm_db.sql", + "patchSetId": 8 + }, + "lineNbr": 111, + "author": { + "id": 28464 + }, + "writtenOn": "2024-04-01T15:53:29Z", + "side": 1, + "message": "nit: same number ordering command applies here.", + "range": { + "startLine": 108, + "startChar": 0, + "endLine": 111, + "endChar": 109 + }, + "revId": "10dfa8a9c436e39037ba37a7492a1ebd122c54a2", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + } + ] +} \ No newline at end of file