starlingx
/
ha
Code Issues Proposed changes

Update robot comments

This commit is contained in:
Gerrit User 22348 2024-01-17 21:08:05 +00:00 committed by Gerrit Code Review
commit 49d8c8b398
1 changed files with 67 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

67
17ae10b8711306896874e775d4b92548e54653de Normal file
View File

@ -0,0 +1,67 @@
{
"comments": [
{
"robotId": "zuul",
"robotRunId": "5202dbccdc6b442da23022a6d582831c",
"url": "https://zuul.opendev.org/t/openstack/buildset/5202dbccdc6b442da23022a6d582831c",
"fixSuggestions": [],
"key": {
"uuid": "c611c4a8_1fe89423",
"filename": "service-mgmt-api/sm-api/sm_api/api/controllers/v1/servicenode.py",
"patchSetId": 1
},
"lineNbr": 451,
"author": {
"id": 22348
},
"writtenOn": "2024-01-17T21:08:05Z",
"side": 1,
"message": "pylint: E0213: Method \u0027_get_endpoint\u0027 should have \"self\" as first argument (no-self-argument)",
"tag": "autogenerated:zuul:check",
"revId": "17ae10b8711306896874e775d4b92548e54653de",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"robotId": "zuul",
"robotRunId": "5202dbccdc6b442da23022a6d582831c",
"url": "https://zuul.opendev.org/t/openstack/buildset/5202dbccdc6b442da23022a6d582831c",
"fixSuggestions": [],
"key": {
"uuid": "6e572cbd_2815ec4c",
"filename": "service-mgmt-api/sm-api/sm_api/api/controllers/v1/servicenode.py",
"patchSetId": 1
},
"lineNbr": 492,
"author": {
"id": 22348
},
"writtenOn": "2024-01-17T21:08:05Z",
"side": 1,
"message": "pep8: B012 return/continue/break inside finally blocks cause exceptions to be silenced. Exceptions should be silenced in except blocks. Control statements can be moved outside the finally block.",
"tag": "autogenerated:zuul:check",
"revId": "17ae10b8711306896874e775d4b92548e54653de",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"robotId": "zuul",
"robotRunId": "5202dbccdc6b442da23022a6d582831c",
"url": "https://zuul.opendev.org/t/openstack/buildset/5202dbccdc6b442da23022a6d582831c",
"fixSuggestions": [],
"key": {
"uuid": "34179e05_b60d61e6",
"filename": "service-mgmt-api/sm-api/sm_api/api/controllers/v1/servicenode.py",
"patchSetId": 1
},
"lineNbr": 492,
"author": {
"id": 22348
},
"writtenOn": "2024-01-17T21:08:05Z",
"side": 1,
"message": "pylint: W0150: return statement in finally block may swallow exception (lost-exception)",
"tag": "autogenerated:zuul:check",
"revId": "17ae10b8711306896874e775d4b92548e54653de",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}