starlingx
/
ha
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: -Code-Review

(1 comment)

Patch-set: 2
Label: Code-Review=0, 065c29cf350ffe5cd6624ae46436862fa1f73602
This commit is contained in:
Gerrit User 28466 2024-01-30 17:05:46 +00:00 committed by Gerrit Code Review
parent a0e9305377
commit e403963c90
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
cde5309dd25e37a8b415f08589bdbbe63776c5e3
View File

@ -67,6 +67,29 @@
"message": "recheck",
"revId": "cde5309dd25e37a8b415f08589bdbbe63776c5e3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "19b3e658_a7a486e9",
"filename": "service-mgmt-api/sm-api/sm_api/api/controllers/v1/servicenode.py",
"patchSetId": 2
},
"lineNbr": 501,
"author": {
"id": 28466
},
"writtenOn": "2024-01-30T17:05:46Z",
"side": 1,
"message": "_get_endpoint may return None, to fail the operation here.\nNeed to avoid a failure which blocks swact. swact should be blocked only when out-of-sync is certain.",
"range": {
"startLine": 501,
"startChar": 0,
"endLine": 501,
"endChar": 76
},
"revId": "cde5309dd25e37a8b415f08589bdbbe63776c5e3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}