From 8350ded5fcd9f48e7dbcdde68c70557971e0d3d8 Mon Sep 17 00:00:00 2001 From: Austin Date: Fri, 21 Dec 2018 15:21:29 +0800 Subject: [PATCH] Fix a major logic error If in_transition is false, the result of in_transition is always false with '&&', so we should be changed '&&' to '||'. Change-Id: I8c18c052c94ebfdbcbcec215d64a8bceeda34f27 Closes-Bug: #1809412 --- service-mgmt/sm-1.0.0/src/sm_failover.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/service-mgmt/sm-1.0.0/src/sm_failover.c b/service-mgmt/sm-1.0.0/src/sm_failover.c index c55bc118..0139c1d2 100644 --- a/service-mgmt/sm-1.0.0/src/sm_failover.c +++ b/service-mgmt/sm-1.0.0/src/sm_failover.c @@ -910,13 +910,13 @@ void sm_failover_audit() bool in_transition = false; bool infra_configured = is_infra_configured(); - in_transition = in_transition && + in_transition = in_transition || sm_failover_if_transit_state(_mgmt_interface_info); - in_transition = in_transition && + in_transition = in_transition || sm_failover_if_transit_state(_oam_interface_info); if( infra_configured ) { - in_transition = in_transition && + in_transition = in_transition || sm_failover_if_transit_state(_infra_interface_info); }