starlingx
/
integ
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review-1

(1 comment)

Patch-set: 3
Reviewer: Gerrit User 8768 <8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, f448065bdeeb605845c369d41f7d2035c2b305c3
This commit is contained in:
Gerrit User 8768 2024-04-05 22:51:13 +00:00 committed by Gerrit Code Review
parent 5a80209432
commit 08eaccb764
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
6f725e19d60535b3896db2dda83afeaa5405eae6
View File

@ -98,6 +98,29 @@
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f64bd2a4_62f9efc7",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 98,
"author": {
"id": 8768
},
"writtenOn": "2024-04-05T22:51:13Z",
"side": 1,
"message": "this shouldn\u0027t be hardcoded, there is a default in the Kubelet code but it can be overridden via the --kubeconfig runtime flag\n\n\nAlso, why do we need to make a new k8sclient? Doesn\u0027t kubelet already talk to the K8s API? And do we really want to be creating a new connection to the K8s API server every time we try to schedule a pod?",
"range": {
"startLine": 98,
"startChar": 43,
"endLine": 98,
"endChar": 71
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {