starlingx
/
integ
Code Issues Proposed changes

Update patch set 7 

Patch Set 7:

(1 comment)

Patch-set: 7
Attention: {"person_ident":"Gerrit User 34926 \u003c34926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28464\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28464 \u003c28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28464\u003e replied on the change"}
This commit is contained in:
Gerrit User 28464 2024-04-22 20:39:43 +00:00 committed by Gerrit Code Review
parent 412946a8b0
commit cf973f6eab
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
fb3206c062e5f24648ead7f1459e5a2e59dfba09
View File

@ -46,6 +46,30 @@
},
"revId": "fb3206c062e5f24648ead7f1459e5a2e59dfba09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "240346da_c4183a64",
"filename": "ceph/ceph/debian/deb_folder/ceph-base.ceph.init",
"patchSetId": 7
},
"lineNbr": 135,
"author": {
"id": 28464
},
"writtenOn": "2024-04-22T20:39:43Z",
"side": 1,
"message": "I really don\u0027t think ilog was ever intended to mean \u0027internal\u0027, but I suppose it could.\n\nI always thought ilog meant \u0027Info Log\u0027 , wlog is Warning Log, elog is Error Log.\nThese are log macro names used in mtce and quite commonly adopted throughout a lot of starlingX scripting.\n\nThose wlog(s) you are changing to ilog(s) seem to be ERROR logs.\nI feel changing it from wlog to ilog is downgrading the severity of the call and feels misleading. Would you consider creating an elog or warn_log. Something that carries the meaning behind the log.\n\nAlso, could you show an example as a comment or better yet in the commit message of the logging change.",
"parentUuid": "3a5f1864_9a971340",
"range": {
"startLine": 135,
"startChar": 8,
"endLine": 135,
"endChar": 9
},
"revId": "fb3206c062e5f24648ead7f1459e5a2e59dfba09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}