95 lines
3.4 KiB
Plaintext
95 lines
3.4 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "8fc66486_4b2ebfbb",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 39,
|
|
"author": {
|
|
"id": 8768
|
|
},
|
|
"writtenOn": "2024-04-19T20:04:20Z",
|
|
"side": 1,
|
|
"message": "should probably have a story/task here as well since there\u0027s more than just the bugfix.\n\nProbably want to put it under story 2010612",
|
|
"revId": "af6fb37a3bf4b5813982e024297676a55843dbfa",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "901d145d_bae52ed4",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 8768
|
|
},
|
|
"writtenOn": "2024-04-17T22:41:53Z",
|
|
"side": 1,
|
|
"message": "For K8s 1.25-1.29 this looks good. For 1.24 I\u0027m not sure if we want to get rid of the hardcoded list, it might simplify things during upgrades for platform Pods that don\u0027t yet have the Pod/Namespace platform label.",
|
|
"revId": "af6fb37a3bf4b5813982e024297676a55843dbfa",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "5c05d31e_22375d7d",
|
|
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 73,
|
|
"author": {
|
|
"id": 8768
|
|
},
|
|
"writtenOn": "2024-04-18T16:09:54Z",
|
|
"side": 1,
|
|
"message": "for 1.24.4 I don\u0027t think we can remove this, since during a platform upgrade the \"old\" applications (which may not have the new-style Pod/Namespace platform label) will still be running.\n\nAfter the platform upgrade completes we should upgrade the applications, so for K8s 1.25 and later we should be able to drop the hardcoded list.",
|
|
"range": {
|
|
"startLine": 69,
|
|
"startChar": 0,
|
|
"endLine": 73,
|
|
"endChar": 1
|
|
},
|
|
"revId": "af6fb37a3bf4b5813982e024297676a55843dbfa",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ad3daee3_ce08a5c7",
|
|
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 105,
|
|
"author": {
|
|
"id": 33814
|
|
},
|
|
"writtenOn": "2024-04-17T16:02:13Z",
|
|
"side": 1,
|
|
"message": "As kubelet KUBECONFIG is now \"kubeConfigPath\", log message should also be changed to use the non hardcoded path, otherwise it will mislead.",
|
|
"revId": "af6fb37a3bf4b5813982e024297676a55843dbfa",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b24a4bac_b6ba19a2",
|
|
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 111,
|
|
"author": {
|
|
"id": 33814
|
|
},
|
|
"writtenOn": "2024-04-17T16:02:13Z",
|
|
"side": 1,
|
|
"message": "Same as above.",
|
|
"revId": "af6fb37a3bf4b5813982e024297676a55843dbfa",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |