integ/6f725e19d60535b3896db2dda83...

616 lines
20 KiB
Plaintext

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "7d96fc20_e96666e9",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 8768
},
"writtenOn": "2024-04-05T22:10:07Z",
"side": 1,
"message": "for the next K8s version it would probably make sense to merge this patch in with kubelet-cpumanager-infra-pods-use-system-reserved-CP.patch since much of that patch will be overridden by this one.",
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3c434cd7_6613f869",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 48,
"author": {
"id": 8768
},
"writtenOn": "2024-04-05T22:26:49Z",
"side": 1,
"message": "may want to add a comment explaining that these are specified as variables so that they can more easily be overridden during testing.",
"range": {
"startLine": 42,
"startChar": 0,
"endLine": 48,
"endChar": 35
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c628f7df_eb091978",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 48,
"author": {
"id": 35284
},
"writtenOn": "2024-04-16T14:04:41Z",
"side": 1,
"message": "Done",
"parentUuid": "3c434cd7_6613f869",
"range": {
"startLine": 42,
"startChar": 0,
"endLine": 48,
"endChar": 35
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ed524c6d_08ab6c12",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 63,
"author": {
"id": 35757
},
"writtenOn": "2024-04-05T14:42:26Z",
"side": 1,
"message": "Repeating this same definition across the patches could be error prone. Is there a way to define this in on common file?",
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "fd164479_c387c464",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 63,
"author": {
"id": 8768
},
"writtenOn": "2024-04-05T22:26:49Z",
"side": 1,
"message": "we\u0027re actually removing this definition. But we\u0027re generally making the same set of changes across each version of K8s so it might be worth considering if there are tools to make that quicker.",
"parentUuid": "ed524c6d_08ab6c12",
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8bfb6c06_5670d6a4",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 63,
"author": {
"id": 35284
},
"writtenOn": "2024-04-16T14:04:41Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "fd164479_c387c464",
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a62b1337_99587934",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 76,
"author": {
"id": 8768
},
"writtenOn": "2024-04-05T22:26:49Z",
"side": 1,
"message": "why not define these during init() as well?",
"range": {
"startLine": 75,
"startChar": 0,
"endLine": 76,
"endChar": 58
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "bfadc521_4672b3ad",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 76,
"author": {
"id": 33814
},
"writtenOn": "2024-04-11T19:46:25Z",
"side": 1,
"message": "Good idea.",
"parentUuid": "a62b1337_99587934",
"range": {
"startLine": 75,
"startChar": 0,
"endLine": 76,
"endChar": 58
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8c0172db_ac6cdba8",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 76,
"author": {
"id": 35284
},
"writtenOn": "2024-04-16T14:04:41Z",
"side": 1,
"message": "Done",
"parentUuid": "bfadc521_4672b3ad",
"range": {
"startLine": 75,
"startChar": 0,
"endLine": 76,
"endChar": 58
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f64bd2a4_62f9efc7",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 98,
"author": {
"id": 8768
},
"writtenOn": "2024-04-05T22:51:13Z",
"side": 1,
"message": "this shouldn\u0027t be hardcoded, there is a default in the Kubelet code but it can be overridden via the --kubeconfig runtime flag\n\n\nAlso, why do we need to make a new k8sclient? Doesn\u0027t kubelet already talk to the K8s API? And do we really want to be creating a new connection to the K8s API server every time we try to schedule a pod?",
"range": {
"startLine": 98,
"startChar": 43,
"endLine": 98,
"endChar": 71
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "09777c45_12e084ee",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 98,
"author": {
"id": 33814
},
"writtenOn": "2024-04-11T19:46:25Z",
"side": 1,
"message": "When I was trying to find out how kubelet communicates with kube-apiserver, this is what I could come up with. Even I was looking for a pre-existing object or connection for kubelet-apiserver communication. I even asked on the community slack channel (unanswered). This was the only way I could come up with. Kubernetes code is quite vast. \n\nWe can pre-create a connection object just once when the kubelet is started (and maintain it as a global variable inside the code) and use it for the CPU allocation for each pod whenever required. But I guess users must be staying for one type of static allocation for long and doubt if they might be changing CPU allocation often. So we might be blocking a memory block which is used less frequently. It doesn\u0027t sound too much memory expensive though. \n\nRegarding /etc/kubernetes/kubelet.conf, I did realize that it should not be hardcoded. I looked for a constant like \"KUBECONFIG\" or something. I temporarily hardcoded it to test the logic and missed to get back to it. Good point.",
"parentUuid": "f64bd2a4_62f9efc7",
"range": {
"startLine": 98,
"startChar": 43,
"endLine": 98,
"endChar": 71
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b71db21b_f385db35",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 98,
"author": {
"id": 8768
},
"writtenOn": "2024-04-18T16:36:45Z",
"side": 1,
"message": "Looks like the existing K8s API client is kubeDeps.KubeClient in pkg/kubelet/kubelet.go\n\nI don\u0027t know if we can practically use it down in pkg/kubelet/cm/cpumanager/policy_static.go though. Might need to make a helper function like nodeLister and pass it all the way down.",
"parentUuid": "09777c45_12e084ee",
"range": {
"startLine": 98,
"startChar": 43,
"endLine": 98,
"endChar": 71
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "bec7a3c2_3f9d5fb2",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 120,
"author": {
"id": 8768
},
"writtenOn": "2024-04-05T23:33:10Z",
"side": 1,
"message": "is labelled as platform pod or is in a namespace labelled as a platform namespace",
"range": {
"startLine": 120,
"startChar": 25,
"endLine": 120,
"endChar": 66
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c2c2318c_446c5abb",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 120,
"author": {
"id": 35284
},
"writtenOn": "2024-04-16T14:04:41Z",
"side": 1,
"message": "Done",
"parentUuid": "bec7a3c2_3f9d5fb2",
"range": {
"startLine": 120,
"startChar": 25,
"endLine": 120,
"endChar": 66
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6b9ce198_bfadc5f3",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 134,
"author": {
"id": 8768
},
"writtenOn": "2024-04-05T23:33:10Z",
"side": 1,
"message": "this function doesn\u0027t have anything to do with assigning CPUs, so should probably change this to something like \"Treating as platform pod.\"",
"range": {
"startLine": 134,
"startChar": 81,
"endLine": 134,
"endChar": 105
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3be42a6f_4cfe30fc",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 134,
"author": {
"id": 35284
},
"writtenOn": "2024-04-16T14:04:41Z",
"side": 1,
"message": "Done",
"parentUuid": "6b9ce198_bfadc5f3",
"range": {
"startLine": 134,
"startChar": 81,
"endLine": 134,
"endChar": 105
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9de6ac86_e08eb6d6",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 138,
"author": {
"id": 8768
},
"writtenOn": "2024-04-05T23:33:10Z",
"side": 1,
"message": "maybe better as a debug log?",
"range": {
"startLine": 138,
"startChar": 4,
"endLine": 138,
"endChar": 136
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ea34daca_bf12eb77",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 138,
"author": {
"id": 35284
},
"writtenOn": "2024-04-16T14:04:41Z",
"side": 1,
"message": "Done",
"parentUuid": "9de6ac86_e08eb6d6",
"range": {
"startLine": 138,
"startChar": 4,
"endLine": 138,
"endChar": 136
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1bac5ece_d1e83cd9",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 148,
"author": {
"id": 8768
},
"writtenOn": "2024-04-05T23:33:10Z",
"side": 1,
"message": "maybe \"Treating as platform pod.\" ?",
"range": {
"startLine": 148,
"startChar": 125,
"endLine": 148,
"endChar": 148
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2c17d6d7_160240b5",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 148,
"author": {
"id": 35284
},
"writtenOn": "2024-04-16T14:04:41Z",
"side": 1,
"message": "Done",
"parentUuid": "1bac5ece_d1e83cd9",
"range": {
"startLine": 148,
"startChar": 125,
"endLine": 148,
"endChar": 148
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "02bd958f_9cde0caf",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 152,
"author": {
"id": 8768
},
"writtenOn": "2024-04-05T23:33:10Z",
"side": 1,
"message": "maybe \"Not treating as platform pod.\" ?",
"range": {
"startLine": 152,
"startChar": 130,
"endLine": 152,
"endChar": 160
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d3b55190_c3dcf8fd",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 152,
"author": {
"id": 35284
},
"writtenOn": "2024-04-16T14:04:41Z",
"side": 1,
"message": "Done",
"parentUuid": "02bd958f_9cde0caf",
"range": {
"startLine": 152,
"startChar": 130,
"endLine": 152,
"endChar": 160
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2a44dfc9_4c4ed47f",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 311,
"author": {
"id": 8768
},
"writtenOn": "2024-04-05T23:33:10Z",
"side": 1,
"message": "for completeness, might want to test pod and platform with platform label",
"range": {
"startLine": 306,
"startChar": 0,
"endLine": 311,
"endChar": 68
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "7af32b7d_db341ff1",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 311,
"author": {
"id": 35284
},
"writtenOn": "2024-04-16T14:04:41Z",
"side": 1,
"message": "Done",
"parentUuid": "2a44dfc9_4c4ed47f",
"range": {
"startLine": 306,
"startChar": 0,
"endLine": 311,
"endChar": 68
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8246f7d4_4791300c",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 381,
"author": {
"id": 8768
},
"writtenOn": "2024-04-05T22:26:49Z",
"side": 1,
"message": "where is this coming from? Is it pulling in the definition from policy_static_test.go ?",
"range": {
"startLine": 381,
"startChar": 19,
"endLine": 381,
"endChar": 39
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d7a2f50b_f8b1ef99",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 381,
"author": {
"id": 33814
},
"writtenOn": "2024-04-11T19:46:25Z",
"side": 1,
"message": "Yes",
"parentUuid": "8246f7d4_4791300c",
"range": {
"startLine": 381,
"startChar": 19,
"endLine": 381,
"endChar": 39
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b60c54c9_f022c35a",
"filename": "kubernetes/kubernetes-1.24.4/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 3
},
"lineNbr": 381,
"author": {
"id": 35284
},
"writtenOn": "2024-04-22T16:25:25Z",
"side": 1,
"message": "Done",
"parentUuid": "d7a2f50b_f8b1ef99",
"range": {
"startLine": 381,
"startChar": 19,
"endLine": 381,
"endChar": 39
},
"revId": "6f725e19d60535b3896db2dda83afeaa5405eae6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}