133 lines
4.6 KiB
Plaintext
133 lines
4.6 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "00c86283_0933c4aa",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 24777
|
|
},
|
|
"writtenOn": "2024-04-19T22:54:04Z",
|
|
"side": 1,
|
|
"message": "I think this code looks fine, and your testing worked:: but I wonder if we need to add something under https://opendev.org/starlingx/apt-ostree/src/branch/master/config/starlingx/bootstrap.yaml#L293 ?\n\nI\u0027m honestly not sure (just looking at other puppet modules stx creates debian packages for), but I\u0027d like to remove my +2 before the weekend",
|
|
"revId": "bd90e442ac4aa8b5caa5825e873ed0e188b7eb05",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "42cf6075_b3850e9c",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 36411
|
|
},
|
|
"writtenOn": "2024-04-22T14:28:58Z",
|
|
"side": 1,
|
|
"message": "I don\u0027t see similar package puppet-zitrlp-strongswan on this file too. Not sure relevant or not though.",
|
|
"parentUuid": "00c86283_0933c4aa",
|
|
"revId": "bd90e442ac4aa8b5caa5825e873ed0e188b7eb05",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "fd5c1952_75af8813",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 24777
|
|
},
|
|
"writtenOn": "2024-04-22T16:57:11Z",
|
|
"side": 1,
|
|
"message": "After consulting with apt-ostree repo folks, there is no need to update further.",
|
|
"revId": "bd90e442ac4aa8b5caa5825e873ed0e188b7eb05",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
],
|
|
"submitRequirementResults": [
|
|
{
|
|
"submitRequirement": {
|
|
"name": "Code-Review",
|
|
"description": {
|
|
"value": "Code reviewed by core reviewer"
|
|
},
|
|
"applicabilityExpression": {},
|
|
"submittabilityExpression": {
|
|
"expressionString": "label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN"
|
|
},
|
|
"overrideExpression": {},
|
|
"allowOverrideInChildProjects": true
|
|
},
|
|
"applicabilityExpressionResult": {},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"label:Code-Review=MAX AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX"],"failingAtoms":["label:Code-Review=MIN"]}
|
|
},
|
|
"overrideExpressionResult": {},
|
|
"patchSetCommitId": "bd90e442ac4aa8b5caa5825e873ed0e188b7eb05",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
},
|
|
{
|
|
"submitRequirement": {
|
|
"name": "Verified",
|
|
"description": {
|
|
"value": "Verified in gate by CI"
|
|
},
|
|
"applicabilityExpression": {},
|
|
"submittabilityExpression": {
|
|
"expressionString": "label:Verified\u003dMAX AND -label:Verified\u003dMIN"
|
|
},
|
|
"overrideExpression": {},
|
|
"allowOverrideInChildProjects": false
|
|
},
|
|
"applicabilityExpressionResult": {},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"label:Verified=MAX AND -label:Verified=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Verified=MAX"],"failingAtoms":["label:Verified=MIN"]}
|
|
},
|
|
"overrideExpressionResult": {},
|
|
"patchSetCommitId": "bd90e442ac4aa8b5caa5825e873ed0e188b7eb05",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
},
|
|
{
|
|
"submitRequirement": {
|
|
"name": "Workflow",
|
|
"description": {
|
|
"value": "Approved for gate by core reviewer"
|
|
},
|
|
"applicabilityExpression": {},
|
|
"submittabilityExpression": {
|
|
"expressionString": "label:Workflow\u003dMAX AND -label:Workflow\u003dMIN"
|
|
},
|
|
"overrideExpression": {},
|
|
"allowOverrideInChildProjects": false
|
|
},
|
|
"applicabilityExpressionResult": {},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"label:Workflow=MAX AND -label:Workflow=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Workflow=MAX"],"failingAtoms":["label:Workflow=MIN"]}
|
|
},
|
|
"overrideExpressionResult": {},
|
|
"patchSetCommitId": "bd90e442ac4aa8b5caa5825e873ed0e188b7eb05",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
}
|
|
]
|
|
} |