integ/config
Daniel Badea 2936d5d568 ceph-disk prepare invalid data disk value
ceph-disk prepare data OSD parameter contains a new line causing
puppet manifest to fail:

1. $data = generate('/bin/bash','-c',"/bin/readlink -f ${name}")

   is expanded together with a new line in:

   exec { $ceph_prepare:
     command   => "/usr/sbin/ceph-disk prepare ${cluster_option}
                    ${cluster_uuid_option} ${uuid_option}
                    --fs-type xfs --zap-disk ${data} ${journal}"

   just before ${journal} is expanded. Puppet reports:

     sh: line 1: : command not found

   when trying to run '' (default journal value).

2. 'readlink' should be called when running ceph-disk prepare
   command, not when the puppet resource is defined. Let
   exec's shell call readlink instead of using puppet's
   generate() . See also:

     ff2b2e6898

Added --verbose and --log-stdout options to log commands executed
by 'ceph-disk prepare' and identify where it fails.

Closes-Bug: 1800889
Change-Id: I6b71147706edb97d5a1e6579924d45b999efe98f
Signed-off-by: Daniel Badea <daniel.badea@windriver.com>
2018-10-31 19:55:26 +00:00
..
facter/centos de-fuzz facter patch 2018-10-09 23:00:20 +08:00
puppet-4.8.2/centos de-fuzz puppet patch 2018-10-09 23:01:46 +08:00
puppet-modules ceph-disk prepare invalid data disk value 2018-10-31 19:55:26 +00:00