starlingx
/
metal
Code Issues Proposed changes

Fix rare mtcAgent segfault on process shutdown 

A mtcAgent core dump was observed during unit testing
of another feature. Debug of that coredump revealed the
segfault occured in the freeing of host object memory.

Occurrence is extremely rare but at the same time there
is no real need to free this memory in the destructor
because the kernel, which is much better at that task,
does that automatically when a proccess exits.

Test Plan:

PASS: Verify system install with no core dumps.
PASS: Verify mtcAgent proccesss restart soak with no code dumps.

Change-Id: I6107078fb802be0ef2aaf632b79e751376ba9c42
Closes-Bug: 1831956
Signed-off-by: Eric MacDonald <eric.macdonald@windriver.com>
This commit is contained in:
Eric MacDonald 2019-09-29 11:33:42 -04:00
parent f01fd85470
commit 01818fdf09
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
mtce/src/common/nodeClass.cpp
View File

@ -352,14 +352,7 @@ nodeLinkClass::nodeLinkClass()
/* nodeLinkClass destructor */
nodeLinkClass::~nodeLinkClass()
{
/* Free any allocated host memory */
for ( int i = 0 ; i < MAX_HOSTS ; i++ )
{
if ( node_ptrs[i] )
{
delete node_ptrs[i] ;
}
}
;
}
/* Clear start host service controls */