starlingx
/
metal
Code Issues Proposed changes

Change enabled_count variable from bool to int in nodeLinkClass 

The enabled_count member inside nodeLinkClass has a declared bool
datatype, but this variable is used as a counter, where an int data
type is a better choice. This change updates the datatype to int.

Also, there was a misleading-indentation warning in mtcNodeHdlrs.cpp,
which is also fixed in this change.

Change-Id: Ib154c5b6ae2e7068870733b5ee8971e20cedb43f
Story: 2005862
Task: 34163
Signed-off-by: Erich Cordoba <erich.cordoba.malibran@intel.com>
This commit is contained in:
Erich Cordoba 2019-06-17 16:59:27 -05:00
parent 2df0311b29
commit 1292fd8ca0
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mtce/src/common/nodeClass.h
View File

@ -362,7 +362,7 @@ private:
bool inservice_failed_subf ;
/** node has reached enabled state this number of times */
bool enabled_count ;
int enabled_count ;
/** Number of OOS tests run so far */
int oos_test_count ;

8
mtce/src/maintenance/mtcNodeHdlrs.cpp
View File

@ -4612,13 +4612,13 @@ int nodeLinkClass::reboot_handler ( struct nodeLinkClass::node * node_ptr )
{
if ( !node_ptr->mtcCmd_work_fifo.empty() )
node_ptr->mtcCmd_work_fifo.pop_front();
if ( !node_ptr->mtcCmd_work_fifo.empty() )
mtcCmd_workQ_purge ( node_ptr );
if ( !node_ptr->mtcCmd_work_fifo.empty() )
mtcCmd_workQ_purge ( node_ptr );
if ( !node_ptr->mtcCmd_done_fifo.empty() )
node_ptr->mtcCmd_done_fifo.pop_front();
if ( !node_ptr->mtcCmd_done_fifo.empty() )
mtcCmd_doneQ_purge ( node_ptr );
if ( !node_ptr->mtcCmd_done_fifo.empty() )
mtcCmd_doneQ_purge ( node_ptr );
mtcInvApi_force_task ( node_ptr, "" );
adminActionChange ( node_ptr, MTC_ADMIN_ACTION__NONE );