starlingx
/
metal
Code Issues Proposed changes

Remove 15 second delay following Swact Request status update 

The Maintenance swact handler posts swact actions to the host
controller's task status field. The Swact Request posting was
followed by a 15 second wait so that Horizon would be
displaying "Swact: Request" while the swact occurred.

Unfortunately, this delayed the actual swact request for that
entire wait period thereby adding 15 seconds to the overall
manual swact operation.

Since it's better to run swact faster compared to waiting for
the status, this update removes that delay at the risk the
"Swact: Request" status not get displayed prior to the swact
taking place.

Change-Id: I635c896327dca2312efbe02dec67d3e920fa3e90
Closes-Bug: 1895767
Signed-off-by: Eric MacDonald <eric.macdonald@windriver.com>
This commit is contained in:
Eric MacDonald 2020-09-17 21:30:32 -04:00
parent c7e18ca9e9
commit 16fcba3976
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mtce/src/maintenance/mtcNodeHdlrs.cpp
View File

@ -3562,10 +3562,8 @@ int nodeLinkClass::swact_handler ( struct nodeLinkClass::node * node_ptr )
nodeLinkClass::smgrEvent.payload = "" ;
nodeLinkClass::smgrEvent.response = "" ;
/* Post a user message 'Swact: Request' and
* then delay to allow it to be displayed */
/* Post a user message 'Swact: Request' */
mtcInvApi_force_task ( node_ptr, MTC_TASK_SWACT_REQUEST );
mtcTimer_start ( node_ptr->mtcSwact_timer, mtcTimer_handler, (MTC_TASK_UPDATE_DELAY/2) );
node_ptr->swactStage = MTC_SWACT__QUERY ;
break ;
}