starlingx
/
metal
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(2 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28464\u003e replied on the change"}
This commit is contained in:
Gerrit User 28464 2024-02-05 20:45:36 +00:00 committed by Gerrit Code Review
parent 6d15c46674
commit 6189c39ebe
1 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
15aa695b3d43d6e7afe28fa4695e5c56d5f75599
View File

@ -23,6 +23,30 @@
"revId": "15aa695b3d43d6e7afe28fa4695e5c56d5f75599",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "65578faa_b5bccc4c",
"filename": "mtce/src/common/nodeClass.cpp",
"patchSetId": 3
},
"lineNbr": 1403,
"author": {
"id": 28464
},
"writtenOn": "2024-02-05T20:45:36Z",
"side": 1,
"message": "Will update.",
"parentUuid": "c3c796a0_9c8ad165",
"range": {
"startLine": 1403,
"startChar": 33,
"endLine": 1403,
"endChar": 35
},
"revId": "15aa695b3d43d6e7afe28fa4695e5c56d5f75599",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -39,6 +63,24 @@
"message": "I suppose this volatile file would be removed automatically on system restart, however, not on an inservice patch which may restart mtce",
"revId": "15aa695b3d43d6e7afe28fa4695e5c56d5f75599",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c3abb533_28fa9fa6",
"filename": "mtce/src/maintenance/mtcNodeComp.cpp",
"patchSetId": 3
},
"lineNbr": 1171,
"author": {
"id": 28464
},
"writtenOn": "2024-02-05T20:45:36Z",
"side": 1,
"message": "Yes, the volatile file in /var/run has always been removed over a reboot. That is the issue that requires the new non-volatile file.\nYes, but not on a patch and it has been that way forever too.",
"parentUuid": "bfb73f17_da2a7a96",
"revId": "15aa695b3d43d6e7afe28fa4695e5c56d5f75599",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}