Update patch set 2
Patch Set 2: (7 comments) Patch-set: 2
This commit is contained in:
Gerrit User 35148
Gerrit Code Review
parent
ec7927464f
commit
0ae2ac1558
|
|
@ -0,0 +1,27 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "9852de52_d82a0bb9",
|
||||
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/nfvi_infrastructure_api.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 2308,
|
||||
"author": {
|
||||
"id": 35148
|
||||
},
|
||||
"writtenOn": "2024-04-22T16:08:03Z",
|
||||
"side": 0,
|
||||
"message": "This object should be used, will be needed for reentrancy.",
|
||||
"range": {
|
||||
"startLine": 2305,
|
||||
"startChar": 12,
|
||||
"endLine": 2308,
|
||||
"endChar": 21
|
||||
},
|
||||
"revId": "6142d9f11642113cb641d5683e02478c1a011941",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
|
@ -17,6 +17,75 @@
|
|||
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "ae30fb76_dcfb3e5b",
|
||||
"filename": "nfv/nfv-common/nfv_common/tasks/_task_future.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 60,
|
||||
"author": {
|
||||
"id": 35148
|
||||
},
|
||||
"writtenOn": "2024-04-22T16:08:03Z",
|
||||
"side": 1,
|
||||
"message": "The change in config.ini should be enough, this default shouldn\u0027t be changed.",
|
||||
"range": {
|
||||
"startLine": 60,
|
||||
"startChar": 0,
|
||||
"endLine": 60,
|
||||
"endChar": 33
|
||||
},
|
||||
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "d02d76ab_8362a14f",
|
||||
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/nfvi_infrastructure_api.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 2363,
|
||||
"author": {
|
||||
"id": 35148
|
||||
},
|
||||
"writtenOn": "2024-04-22T16:08:03Z",
|
||||
"side": 1,
|
||||
"message": "TODO?",
|
||||
"range": {
|
||||
"startLine": 2354,
|
||||
"startChar": 1,
|
||||
"endLine": 2363,
|
||||
"endChar": 54
|
||||
},
|
||||
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "303ad34c_303cf887",
|
||||
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/openstack/rest_api.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 476,
|
||||
"author": {
|
||||
"id": 35148
|
||||
},
|
||||
"writtenOn": "2024-04-22T16:08:03Z",
|
||||
"side": 1,
|
||||
"message": "This shouldn\u0027t need to be changed since you changed the timeout in \nnfv/nfv-plugins/nfv_plugins/nfvi_plugins/openstack/usm.py?\n\nIf this one gets changed you technically should test every strategy...",
|
||||
"range": {
|
||||
"startLine": 476,
|
||||
"startChar": 21,
|
||||
"endLine": 476,
|
||||
"endChar": 41
|
||||
},
|
||||
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -39,6 +108,69 @@
|
|||
},
|
||||
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "7b349a35_b80dd2f7",
|
||||
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 1840,
|
||||
"author": {
|
||||
"id": 35148
|
||||
},
|
||||
"writtenOn": "2024-04-22T16:08:03Z",
|
||||
"side": 1,
|
||||
"message": "This should be in the sw precheck step",
|
||||
"range": {
|
||||
"startLine": 1809,
|
||||
"startChar": 1,
|
||||
"endLine": 1840,
|
||||
"endChar": 0
|
||||
},
|
||||
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "19fba6e7_2f72a3ba",
|
||||
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 1858,
|
||||
"author": {
|
||||
"id": 35148
|
||||
},
|
||||
"writtenOn": "2024-04-22T16:08:03Z",
|
||||
"side": 1,
|
||||
"message": "precheck should be after QueryUpgradeStep",
|
||||
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "83d210f1_cddc0df1",
|
||||
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 1122,
|
||||
"author": {
|
||||
"id": 35148
|
||||
},
|
||||
"writtenOn": "2024-04-22T16:08:03Z",
|
||||
"side": 1,
|
||||
"message": "Should have been response[\u0027result-data\u0027][\u0027release_info\u0027][\u0027state\u0027]",
|
||||
"range": {
|
||||
"startLine": 1122,
|
||||
"startChar": 60,
|
||||
"endLine": 1122,
|
||||
"endChar": 92
|
||||
},
|
||||
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue