starlingx
/
nfv
Code Issues Proposed changes

Update patch set 14 

Patch Set 14:

(4 comments)

Patch-set: 14
Attention: {"person_ident":"Gerrit User 35148 \u003c35148@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35148\u003e replied on the change"}
This commit is contained in:
Gerrit User 35148 2024-04-15 14:10:55 +00:00 committed by Gerrit Code Review
parent c3139fea66
commit 18838f50d6
1 changed files with 96 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
94ec121a6a89733b90554cc318c2e6bb2f00caef
View File

@ -23,6 +23,30 @@
"revId": "94ec121a6a89733b90554cc318c2e6bb2f00caef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c3286d03_129dc731",
"filename": "nfv/nfv-vim/nfv_vim/directors/_host_director.py",
"patchSetId": 13
},
"lineNbr": 697,
"author": {
"id": 35148
},
"writtenOn": "2024-04-15T14:10:55Z",
"side": 1,
"message": "Yes. USM will support reboot required and no reboot required.",
"parentUuid": "4364c363_c5854f8d",
"range": {
"startLine": 696,
"startChar": 12,
"endLine": 697,
"endChar": 57
},
"revId": "94ec121a6a89733b90554cc318c2e6bb2f00caef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -46,6 +70,30 @@
"revId": "94ec121a6a89733b90554cc318c2e6bb2f00caef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "92ff20f9_e8ac1cb1",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
"patchSetId": 13
},
"lineNbr": 1264,
"author": {
"id": 35148
},
"writtenOn": "2024-04-15T14:10:55Z",
"side": 1,
"message": "Fixed typo.\n\nThis change would impact every strategy and is out of scope. Strategies are essentially running empty steps because instance_list is not checked.",
"parentUuid": "54a99c38_d1777447",
"range": {
"startLine": 1263,
"startChar": 20,
"endLine": 1264,
"endChar": 66
},
"revId": "94ec121a6a89733b90554cc318c2e6bb2f00caef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -69,6 +117,30 @@
"revId": "94ec121a6a89733b90554cc318c2e6bb2f00caef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f02de686_446941ca",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
"patchSetId": 13
},
"lineNbr": 1809,
"author": {
"id": 35148
},
"writtenOn": "2024-04-15T14:10:55Z",
"side": 1,
"message": "Done",
"parentUuid": "49c5068e_88399661",
"range": {
"startLine": 1809,
"startChar": 19,
"endLine": 1809,
"endChar": 28
},
"revId": "94ec121a6a89733b90554cc318c2e6bb2f00caef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -91,6 +163,30 @@
},
"revId": "94ec121a6a89733b90554cc318c2e6bb2f00caef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "26e8bb8c_54a50344",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
"patchSetId": 13
},
"lineNbr": 1916,
"author": {
"id": 35148
},
"writtenOn": "2024-04-15T14:10:55Z",
"side": 1,
"message": "Done",
"parentUuid": "043980f2_e9bcd7c5",
"range": {
"startLine": 1916,
"startChar": 51,
"endLine": 1916,
"endChar": 57
},
"revId": "94ec121a6a89733b90554cc318c2e6bb2f00caef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}